Fixed naming bug for argument of aws_appflow_flow resource

[jclRatepay]

Description

Fixed naming bug for argument of "source_connector_properties.0.sao_data" schema of "aws_appflow_flow" resource and adjusted documentation accordingly to match actual argument implementation. This change is required to make creating a new AWS AppFlow flow resource having a SAP OData connector configured as source via Terraform possible.

Relations

Closes #28552

References

Output from Acceptance Testing

Checking the available acceptance tests I quickly realized that due to the huge amount of possible argument combinations on the one hand and the necessity for having a huge bunch of third party applications like Salesforce or SAP available no specific tests for that scenario exists.
However, to test the fix I used my local development environment and checked whether creating a AppFlow flow resource via the updated Terraform Provider code is now possible having SAP configured as a source, and it worked as expected and is not failing with errors complaning an invalid implementation or AWS API invocation anymore.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @jclRatepay 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[YakDriver]

LGTM 🎉

% make t T=TestAccAppFlowFlow_ K=appflow
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 20 -run='TestAccAppFlowFlow_'  -timeout 180m
=== RUN   TestAccAppFlowFlow_basic
=== PAUSE TestAccAppFlowFlow_basic
=== RUN   TestAccAppFlowFlow_update
=== PAUSE TestAccAppFlowFlow_update
=== RUN   TestAccAppFlowFlow_TaskProperties
=== PAUSE TestAccAppFlowFlow_TaskProperties
=== RUN   TestAccAppFlowFlow_tags
=== PAUSE TestAccAppFlowFlow_tags
=== RUN   TestAccAppFlowFlow_disappears
=== PAUSE TestAccAppFlowFlow_disappears
=== CONT  TestAccAppFlowFlow_basic
=== CONT  TestAccAppFlowFlow_tags
=== CONT  TestAccAppFlowFlow_disappears
=== CONT  TestAccAppFlowFlow_TaskProperties
=== CONT  TestAccAppFlowFlow_update
--- PASS: TestAccAppFlowFlow_disappears (25.08s)
--- PASS: TestAccAppFlowFlow_TaskProperties (25.73s)
--- PASS: TestAccAppFlowFlow_basic (28.36s)
--- PASS: TestAccAppFlowFlow_update (43.71s)
--- PASS: TestAccAppFlowFlow_tags (63.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	65.411s

[YakDriver]

Normally, changing the name of an argument would be a breaking change. However, in this case, the argument was correctly referenced as object_path in the code, for example, in flex functions, but was defined wrong as object. As a result, the argument has never worked properly. Thus, changing from object (incorrect and not working) to object_path (correct and working) is not a breaking change.

[github-actions]

This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.