Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: aws_dms_endpoint: Remove ignore_headers_row s3 setting #28695

Closed
YakDriver opened this issue Jan 5, 2023 · 4 comments · Fixed by #30452
Closed

[Bug]: aws_dms_endpoint: Remove ignore_headers_row s3 setting #28695

YakDriver opened this issue Jan 5, 2023 · 4 comments · Fixed by #30452
Assignees
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. bug Addresses a defect in current functionality. service/dms Issues and PRs that pertain to the dms service.
Milestone

Comments

@YakDriver
Copy link
Member

YakDriver commented Jan 5, 2023

Terraform Core Version

1.3.7

AWS Provider Version

5.0.0

Affected Resource(s)

  • aws_dms_endpoint

Expected Behavior

This setting should not be there

Actual Behavior

It is

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

resource "aws_dms_endpoint" "test" {
  endpoint_id                 = "appa"
  endpoint_type               = "target"
  engine_name                 = "s3"
  ssl_mode                    = "none"

  s3_settings {
    service_access_role_arn = aws_iam_role.iam_role.arn
    ...
    ignore_headers_row = 1
  }

  depends_on = [aws_iam_role_policy.dms_s3_access]
}

Steps to Reproduce

  1. terraform apply

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

Would you like to implement a fix?

None

@YakDriver YakDriver added bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels Jan 5, 2023
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Jan 5, 2023
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/dms Issues and PRs that pertain to the dms service. label Jan 5, 2023
@YakDriver YakDriver added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. and removed service/dms Issues and PRs that pertain to the dms service. labels Jan 5, 2023
@YakDriver YakDriver added this to the v5.0.0 milestone Jan 5, 2023
@YakDriver YakDriver self-assigned this Apr 19, 2023
@ewbankkit ewbankkit added the service/dms Issues and PRs that pertain to the dms service. label May 3, 2023
@jar-b
Copy link
Member

jar-b commented May 23, 2023

Closed by #30452, merged to main via #31392

@jar-b jar-b closed this as completed May 23, 2023
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. bug Addresses a defect in current functionality. service/dms Issues and PRs that pertain to the dms service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants