[Bug]: Perpetual diffs with aws_iam_role assume_role_policy and Statement.Condition

[YakDriver]

Originally submitted as #23288 (comment) by @cshen-confluent.

Terraform Core Version

1.2.3

AWS Provider Version

4.21.0

Affected Resource(s)

• aws_iam_role

Expected Behavior

Creates and refreshes without changes

Actual Behavior

Role will be updated in-place.

Some information redacted.

I just added a blank line in code and this update plan will be generated among a lot other similar ones, and apply them won't make any actual change. Add another blank line will trigger the same plan.
We did some work to pinpoint the issue on Condition.IpAddress that if we don't put anything there it is fine.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

resource "aws_iam_role" "test" {
  name = "dance-hall-days"
  id.  = "dance-hall-days"

  assume_role_policy = jsonencode({
    Version = "2012-10-17"
    Statement = [{
      Action = "sts:AssumeRoleWithSAML"
      Condition = {
        IpAddress = {
          "aws:SourceIp" = [
            "0.0.0.0/0",
          ]
        }
        StringEquals = {
          "SAML:aud" = "https://signin.aws.amazon.com/saml"
        }
      }
      Principal = {
        Federated = "arn:aws:iam::000000000000:saml-provider/provider"
      }
      Effect = "Allow"
      Sid    = ""
    }]
  })
}

Steps to Reproduce

1. terraform apply
2. terraform apply

Debug Output

  # module.aws_iam_role.some_user_role will be updated in-place
~ resource "aws_iam_role" "some_user_role" {
      ~ assume_role_policy    = jsonencode(
            {
              - Statement = [
                  - {
                      - Action    = "sts:AssumeRoleWithSAML"
                      - Condition = {
                          - IpAddress    = {
                              - aws:SourceIp = [
                                  - "0.0.0.0/0",
                                ]
                            }
                          - StringEquals = {
                              - SAML:aud = "https://signin.aws.amazon.com/saml"
                            }
                        }
                      - Effect    = "Allow"
                      - Principal = {
                          - Federated = "arn:aws:iam::000000000000:saml-provider/provider"
                        }
                      - Sid       = ""
                    },
                ]
              - Version   = "2012-10-17"
            }
        ) -> (known after apply)
        id                    = "administrator"
        name                  = "administrator"
        # (8 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Panic Output

No response

Important Factoids

No response

References

• Perpetual diffs / Objects have changed outside of Terraform (v3.70.0+) #23288 (comment) (@cshen-confluent)

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[github-actions]

This functionality has been released in v4.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.