-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(28538): add manage master user password flag #28848
feat(28538): add manage master user password flag #28848
Conversation
Community NoteVoting for Prioritization
For Submitters
|
What is the correct definition for this attribute? It fails the S019 check , although it does work as intended which is to return the secret ARN that RDS creates to the consumer.
Can I flag it to be ignored (//lintignore:S019) or is there another way to achieve this ? |
Thanks for working on this! Very much looking forward to this functionality. Unless I'm mistaken, similar changes are needed in |
I will take a look today , thanks. |
any update on getting this merged, anything left to do? |
@AdamTylerLynch / @ewbankkit would either of you have time to take a look at the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes requested. I am going to make some code changes on this PR to expedite the merge.
…nagement is enabled/
AccTests for
|
AccTests for
|
AccTests for
|
AccTests for
|
AccTests for
|
Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccRDSInstance_basic\|TestAccRDSInstance_manage_password\|TestAccRDSInstance_ManagedMasterPassword_\|TestAccRDSInstance_password\|TestAccRDSInstanceDataSource_\|TestAccRDSClusterDataSource_\|TestAccRDSCluster_ManagedMasterPassword_\|TestAccRDSCluster_basic\|TestAccRDSCluster_SnapshotIdentifier_master' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3 -run=TestAccRDSInstance_basic\|TestAccRDSInstance_manage_password\|TestAccRDSInstance_ManagedMasterPassword_\|TestAccRDSInstance_password\|TestAccRDSInstanceDataSource_\|TestAccRDSClusterDataSource_\|TestAccRDSCluster_ManagedMasterPassword_\|TestAccRDSCluster_basic\|TestAccRDSCluster_SnapshotIdentifier_master -timeout 360m
=== RUN TestAccRDSClusterDataSource_basic
=== PAUSE TestAccRDSClusterDataSource_basic
=== RUN TestAccRDSClusterDataSource_ManagedMasterPassword_managed
=== PAUSE TestAccRDSClusterDataSource_ManagedMasterPassword_managed
=== RUN TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN TestAccRDSCluster_ManagedMasterPassword_managed
=== PAUSE TestAccRDSCluster_ManagedMasterPassword_managed
=== RUN TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
=== PAUSE TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
=== RUN TestAccRDSCluster_ManagedMasterPassword_convertToManaged
=== PAUSE TestAccRDSCluster_ManagedMasterPassword_convertToManaged
=== RUN TestAccRDSCluster_SnapshotIdentifier_masterPassword
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_masterPassword
=== RUN TestAccRDSCluster_SnapshotIdentifier_masterUsername
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_masterUsername
=== RUN TestAccRDSInstanceDataSource_basic
=== PAUSE TestAccRDSInstanceDataSource_basic
=== RUN TestAccRDSInstanceDataSource_ManagedMasterPassword_managed
=== PAUSE TestAccRDSInstanceDataSource_ManagedMasterPassword_managed
=== RUN TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN TestAccRDSInstance_manage_password
=== PAUSE TestAccRDSInstance_manage_password
=== RUN TestAccRDSInstance_password
=== PAUSE TestAccRDSInstance_password
=== RUN TestAccRDSInstance_ManagedMasterPassword_managed
=== PAUSE TestAccRDSInstance_ManagedMasterPassword_managed
=== RUN TestAccRDSInstance_ManagedMasterPassword_managedSpecificKMSKey
=== PAUSE TestAccRDSInstance_ManagedMasterPassword_managedSpecificKMSKey
=== RUN TestAccRDSInstance_ManagedMasterPassword_convertToManaged
=== PAUSE TestAccRDSInstance_ManagedMasterPassword_convertToManaged
=== CONT TestAccRDSClusterDataSource_basic
=== CONT TestAccRDSInstanceDataSource_basic
=== CONT TestAccRDSInstance_password
--- PASS: TestAccRDSClusterDataSource_basic (179.12s)
=== CONT TestAccRDSInstance_ManagedMasterPassword_managedSpecificKMSKey
--- PASS: TestAccRDSInstanceDataSource_basic (468.10s)
=== CONT TestAccRDSInstance_ManagedMasterPassword_convertToManaged
--- PASS: TestAccRDSInstance_password (582.65s)
=== CONT TestAccRDSInstance_basic
--- PASS: TestAccRDSInstance_ManagedMasterPassword_managedSpecificKMSKey (513.79s)
=== CONT TestAccRDSInstance_manage_password
--- PASS: TestAccRDSInstance_basic (404.12s)
=== CONT TestAccRDSInstanceDataSource_ManagedMasterPassword_managed
--- PASS: TestAccRDSInstance_ManagedMasterPassword_convertToManaged (682.88s)
=== CONT TestAccRDSInstance_ManagedMasterPassword_managed
--- PASS: TestAccRDSInstance_manage_password (540.26s)
=== CONT TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey (158.38s)
=== CONT TestAccRDSCluster_SnapshotIdentifier_masterUsername
--- PASS: TestAccRDSInstanceDataSource_ManagedMasterPassword_managed (543.98s)
=== CONT TestAccRDSCluster_SnapshotIdentifier_masterPassword
--- PASS: TestAccRDSInstance_ManagedMasterPassword_managed (524.43s)
=== CONT TestAccRDSCluster_ManagedMasterPassword_convertToManaged
--- PASS: TestAccRDSCluster_ManagedMasterPassword_convertToManaged (184.19s)
=== CONT TestAccRDSCluster_basic
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterUsername (439.00s)
=== CONT TestAccRDSCluster_ManagedMasterPassword_managed
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterPassword (388.45s)
=== CONT TestAccRDSClusterDataSource_ManagedMasterPassword_managed
--- PASS: TestAccRDSCluster_basic (171.62s)
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managed (170.96s)
--- PASS: TestAccRDSClusterDataSource_ManagedMasterPassword_managed (210.08s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 2134.054s
@fergoid @AdamTylerLynch Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Testing this as feature has landed in hashicorp/aws v4.61.0 - hashicorp/terraform-provider-aws#28848 - https://docs.aws.amazon.com/secretsmanager/latest/userguide/integrating_how-services-use-secrets_RDS.html
Testing this as feature has landed in hashicorp/aws v4.61.0 - hashicorp/terraform-provider-aws#28848 - https://docs.aws.amazon.com/secretsmanager/latest/userguide/integrating_how-services-use-secrets_RDS.html
Do these tests cover that Terraform picks up |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This pull request adds the option for RDS to manage master user passwords. The default behaviour continues to be to manage passwords as the resource does today.
Relations
Closes #28538
References
Output from Acceptance Testing