r/aws_quicksight_data_source - add secret_arn to credentials

[bennylu2]

Description

Add support for credentials using secret_arn for aws_quicksight_data_source

Relations

Closes #28484

note: I do not have quicksight enabled to run test

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[nam054]

We are currently unable to reliably test this implementation given issues in connecting the QuickSight data source to an RDS instance. We are unable to move forward with this PR for that reason. We are working with AWS support to arrive at a solution and will proceed once unblocked.

[nam054]

LGTM! 🚀 Thank you for your contribution!

> make testacc TESTARGS="-run=TestAccQuickSightDataSource_" PKG=quicksight
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/quicksight/... -v -count 1 -parallel 20  -run=TestAccQuickSightDataSource_ -timeout 360m
=== RUN   TestAccQuickSightDataSource_basic
=== PAUSE TestAccQuickSightDataSource_basic
=== RUN   TestAccQuickSightDataSource_disappears
=== PAUSE TestAccQuickSightDataSource_disappears
=== RUN   TestAccQuickSightDataSource_tags
=== PAUSE TestAccQuickSightDataSource_tags
=== RUN   TestAccQuickSightDataSource_permissions
=== PAUSE TestAccQuickSightDataSource_permissions
=== RUN   TestAccQuickSightDataSource_name
=== PAUSE TestAccQuickSightDataSource_name
=== RUN   TestAccQuickSightDataSource_secretARN
=== PAUSE TestAccQuickSightDataSource_secretARN
=== CONT  TestAccQuickSightDataSource_basic
=== CONT  TestAccQuickSightDataSource_permissions
=== CONT  TestAccQuickSightDataSource_tags
=== CONT  TestAccQuickSightDataSource_name
=== CONT  TestAccQuickSightDataSource_disappears
=== CONT  TestAccQuickSightDataSource_secretARN
--- PASS: TestAccQuickSightDataSource_disappears (24.11s)
--- PASS: TestAccQuickSightDataSource_basic (28.38s)
--- PASS: TestAccQuickSightDataSource_name (43.86s)
--- PASS: TestAccQuickSightDataSource_tags (56.27s)
--- PASS: TestAccQuickSightDataSource_permissions (62.57s)
--- PASS: TestAccQuickSightDataSource_secretARN (822.76s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 827.912s
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  0.461s [no tests to run]

[github-actions]

This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.