Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: kinesis_firehose_delivery_stream #29092

Closed
baolsen opened this issue Jan 25, 2023 · 3 comments · Fixed by #29093
Closed

[Docs]: kinesis_firehose_delivery_stream #29092

baolsen opened this issue Jan 25, 2023 · 3 comments · Fixed by #29093
Labels
documentation Introduces or discusses updates to documentation. service/firehose Issues and PRs that pertain to the firehose service.
Milestone

Comments

@baolsen
Copy link
Contributor

baolsen commented Jan 25, 2023

Documentation Link

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/kinesis_firehose_delivery_stream

Description

There are two minor problems I have found.

1 A delivery stream cannot be updated when enabling dynamic partitioning.

When defining a delivery stream with dynamic partitioning, you must create a new delivery stream and cannot update an existing delivery stream.

This is a known limitation within AWS.
This could be highlighted in the provider documentation to simplify debugging.

The dynamic_partitioning_configuration block makes things confusing because one might assume that this can be toggled. However, changing this configuration does not destroy and recreate the stream (as would be required to effect the change that is desired).

In other words, if you want to enable dynamic partitioning configuration on an existing stream, it must first be deleted, regardless of any configuration.

2 Missing configuration block

You must include the dynamic_partitioning_configuration block otherwise the apply will fail with the error:

Error: creating Kinesis Firehose Delivery Stream: InvalidArgumentException: Dynamic Partitioning Namespaces can only be part of a prefix expression when Dynamic Partitioning is enabled.

The example given in the documentation does not include this block.

The error message therefore is a little ambiguous; it seems to indicate a problem with the prefix expression and it is not obvious that dynamic_partitioning_configuration should be specified.

References

https://docs.aws.amazon.com/firehose/latest/dev/dynamic-partitioning.html

Within "How to enable dynamic partitioning" :

You can enable dynamic partitioning only when you create a new delivery stream. You cannot enable dynamic partitioning for an existing delivery stream that does not have dynamic partitioning already enabled.

Also

Once you enable dynamic partitioning on a delivery stream, it cannot be disabled on this delivery stream.

Would you like to implement a fix?

Yes

@baolsen baolsen added documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. labels Jan 25, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@justinretzolk justinretzolk added service/kinesis Issues and PRs that pertain to the kinesis service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 26, 2023
@johnsonaj johnsonaj added service/firehose Issues and PRs that pertain to the firehose service. and removed service/kinesis Issues and PRs that pertain to the kinesis service. labels Feb 10, 2023
@github-actions github-actions bot added this to the v4.55.0 milestone Feb 10, 2023
@github-actions
Copy link

This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/firehose Issues and PRs that pertain to the firehose service.
Projects
None yet
3 participants