-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Data Source: aws_route53_resolver_query_log_config #29111
New Data Source: aws_route53_resolver_query_log_config #29111
Conversation
Community NoteVoting for Prioritization
For Submitters
|
d23d65e
to
7a884f9
Compare
# Conflicts: # internal/provider/provider.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRoute53ResolverQueryLogConfigDataSource_' PKG=route53resolver
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run=TestAccRoute53ResolverQueryLogConfigDataSource_ -timeout 180m
=== RUN TestAccRoute53ResolverQueryLogConfigDataSource_basic
=== PAUSE TestAccRoute53ResolverQueryLogConfigDataSource_basic
=== RUN TestAccRoute53ResolverQueryLogConfigDataSource_filter
=== PAUSE TestAccRoute53ResolverQueryLogConfigDataSource_filter
=== CONT TestAccRoute53ResolverQueryLogConfigDataSource_basic
=== CONT TestAccRoute53ResolverQueryLogConfigDataSource_filter
--- PASS: TestAccRoute53ResolverQueryLogConfigDataSource_filter (19.04s)
--- PASS: TestAccRoute53ResolverQueryLogConfigDataSource_basic (19.40s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver 24.853s
@ValFadeev Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
aws_route53_resolver_query_log_config
will allow practitioners to retrieve the attributes of Route53 Resolver Query Logging Configurations without having to hardcode them in terraform, which is particularly relevant for multi-region deployments.Relations
Closes #19130
Output from Acceptance Testing