Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: aws_route53_resolver_query_log_config #29111

Conversation

ValFadeev
Copy link
Contributor

@ValFadeev ValFadeev commented Jan 26, 2023

Description

aws_route53_resolver_query_log_config will allow practitioners to retrieve the attributes of Route53 Resolver Query Logging Configurations without having to hardcode them in terraform, which is particularly relevant for multi-region deployments.

Relations

Closes #19130

Output from Acceptance Testing

 % make testacc TESTS=TestAccRoute53ResolverQueryLogConfigDataSource_ PKG=route53resolver
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverQueryLogConfigDataSource_'  -timeout 180m
=== RUN   TestAccRoute53ResolverQueryLogConfigDataSource_basic
=== PAUSE TestAccRoute53ResolverQueryLogConfigDataSource_basic
=== RUN   TestAccRoute53ResolverQueryLogConfigDataSource_filter
=== PAUSE TestAccRoute53ResolverQueryLogConfigDataSource_filter
=== CONT  TestAccRoute53ResolverQueryLogConfigDataSource_basic
=== CONT  TestAccRoute53ResolverQueryLogConfigDataSource_filter
--- PASS: TestAccRoute53ResolverQueryLogConfigDataSource_basic (20.80s)
--- PASS: TestAccRoute53ResolverQueryLogConfigDataSource_filter (22.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	24.185s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53resolver Issues and PRs that pertain to the route53resolver service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Jan 26, 2023
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 26, 2023
@ValFadeev ValFadeev force-pushed the f-aws_route53_resolver_query_log_config_data_source branch from d23d65e to 7a884f9 Compare February 7, 2023 17:14
# Conflicts:
#	internal/provider/provider.go
@github-actions github-actions bot removed the provider Pertains to the provider itself, rather than any interaction with AWS. label Apr 18, 2023
@github-actions github-actions bot added the generators Relates to code generators. label Apr 18, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRoute53ResolverQueryLogConfigDataSource_' PKG=route53resolver
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 20  -run=TestAccRoute53ResolverQueryLogConfigDataSource_ -timeout 180m
=== RUN   TestAccRoute53ResolverQueryLogConfigDataSource_basic
=== PAUSE TestAccRoute53ResolverQueryLogConfigDataSource_basic
=== RUN   TestAccRoute53ResolverQueryLogConfigDataSource_filter
=== PAUSE TestAccRoute53ResolverQueryLogConfigDataSource_filter
=== CONT  TestAccRoute53ResolverQueryLogConfigDataSource_basic
=== CONT  TestAccRoute53ResolverQueryLogConfigDataSource_filter
--- PASS: TestAccRoute53ResolverQueryLogConfigDataSource_filter (19.04s)
--- PASS: TestAccRoute53ResolverQueryLogConfigDataSource_basic (19.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	24.853s

@ewbankkit
Copy link
Contributor

@ValFadeev Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b9cd4c2 into hashicorp:main Apr 18, 2023
@github-actions github-actions bot added this to the v4.64.0 milestone Apr 18, 2023
@github-actions
Copy link

This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a aws_route53_resolver_query_log_config data source
3 participants