-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [appmesh] add logformat field for App Mesh Virtual Node #29315
feat: [appmesh] add logformat field for App Mesh Virtual Node #29315
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Acceptance test output: % make testacc TESTARGS='-run=TestAccAppMesh_serial/VirtualNode/logging' PKG=appmesh ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial/VirtualNode/logging -timeout 180m === RUN TestAccAppMesh_serial === PAUSE TestAccAppMesh_serial === CONT TestAccAppMesh_serial === RUN TestAccAppMesh_serial/VirtualNode === RUN TestAccAppMesh_serial/VirtualNode/logging --- PASS: TestAccAppMesh_serial (37.56s) --- PASS: TestAccAppMesh_serial/VirtualNode (37.56s) --- PASS: TestAccAppMesh_serial/VirtualNode/logging (37.56s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 42.635s
Acceptance test output: % make testacc TESTARGS='-run=TestAccAppMesh_serial/VirtualGateway/logging' PKG=appmesh ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial/VirtualGateway/logging -timeout 180m === RUN TestAccAppMesh_serial === PAUSE TestAccAppMesh_serial === CONT TestAccAppMesh_serial === RUN TestAccAppMesh_serial/VirtualGateway === RUN TestAccAppMesh_serial/VirtualGateway/logging --- PASS: TestAccAppMesh_serial (41.01s) --- PASS: TestAccAppMesh_serial/VirtualGateway (41.01s) --- PASS: TestAccAppMesh_serial/VirtualGateway/logging (41.01s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 47.096s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAppMesh_serial/VirtualGateway/logging' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial/VirtualGateway/logging -timeout 180m
=== RUN TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT TestAccAppMesh_serial
=== RUN TestAccAppMesh_serial/VirtualGateway
=== RUN TestAccAppMesh_serial/VirtualGateway/logging
--- PASS: TestAccAppMesh_serial (41.01s)
--- PASS: TestAccAppMesh_serial/VirtualGateway (41.01s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/logging (41.01s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 47.096s
% make testacc TESTARGS='-run=TestAccAppMesh_serial/VirtualNode/logging' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial/VirtualNode/logging -timeout 180m
=== RUN TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT TestAccAppMesh_serial
=== RUN TestAccAppMesh_serial/VirtualNode
=== RUN TestAccAppMesh_serial/VirtualNode/logging
--- PASS: TestAccAppMesh_serial (37.56s)
--- PASS: TestAccAppMesh_serial/VirtualNode (37.56s)
--- PASS: TestAccAppMesh_serial/VirtualNode/logging (37.56s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 42.635s
@ryoshindo Thanks for the contribution 🎉 👏. I went ahead and added the same for the |
This functionality has been released in v4.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
I have added the logformat field for the App Mesh Virtual Node.
Field names are determined based on the following App Mesh API reference.
https://docs.aws.amazon.com/ja_jp/app-mesh/latest/APIReference/API_FileAccessLog.html#appmesh-Type-FileAccessLog-format
terraform code
I have confirmed that
terraform plan
andterraform apply
are successful in my environment.Please check my pull request.
Relations
Closes #29062.
References
Output from Acceptance Testing