Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route 53: IP-based routing #29407

Merged
merged 21 commits into from
Feb 15, 2023
Merged

Route 53: IP-based routing #29407

merged 21 commits into from
Feb 15, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Feb 14, 2023 •
edited
Loading

Description

Adds support for Route 53 IP-based routing.

New resources:

  • aws_route53_cidr_collection
  • aws_route53_cidr_location

Relations

Closes #25321.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccRoute53CIDRCollection_' PKG=route53 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 3  -run=TestAccRoute53CIDRCollection_ -timeout 180m
=== RUN   TestAccRoute53CIDRCollection_basic
=== PAUSE TestAccRoute53CIDRCollection_basic
=== RUN   TestAccRoute53CIDRCollection_disappears
=== PAUSE TestAccRoute53CIDRCollection_disappears
=== CONT  TestAccRoute53CIDRCollection_basic
=== CONT  TestAccRoute53CIDRCollection_disappears
--- PASS: TestAccRoute53CIDRCollection_disappears (11.97s)
--- PASS: TestAccRoute53CIDRCollection_basic (15.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	20.994s
% make testacc TESTARGS='-run=TestAccRoute53CIDRLocation_' PKG=route53 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 3  -run=TestAccRoute53CIDRLocation_ -timeout 180m
=== RUN   TestAccRoute53CIDRLocation_basic
=== PAUSE TestAccRoute53CIDRLocation_basic
=== RUN   TestAccRoute53CIDRLocation_update
=== PAUSE TestAccRoute53CIDRLocation_update
=== CONT  TestAccRoute53CIDRLocation_basic
=== CONT  TestAccRoute53CIDRLocation_update
--- PASS: TestAccRoute53CIDRLocation_basic (16.99s)
--- PASS: TestAccRoute53CIDRLocation_update (26.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	31.705s
% make testacc TESTARGS='-run=TestAccRoute53Record_' PKG=route53 ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 3  -run=TestAccRoute53Record_ -timeout 180m
=== RUN   TestAccRoute53Record_basic
=== PAUSE TestAccRoute53Record_basic
=== RUN   TestAccRoute53Record_disappears
=== PAUSE TestAccRoute53Record_disappears
=== RUN   TestAccRoute53Record_Disappears_multipleRecords
=== PAUSE TestAccRoute53Record_Disappears_multipleRecords
=== RUN   TestAccRoute53Record_underscored
=== PAUSE TestAccRoute53Record_underscored
=== RUN   TestAccRoute53Record_fqdn
=== PAUSE TestAccRoute53Record_fqdn
=== RUN   TestAccRoute53Record_trailingPeriodAndZoneID
=== PAUSE TestAccRoute53Record_trailingPeriodAndZoneID
=== RUN   TestAccRoute53Record_Support_txt
=== PAUSE TestAccRoute53Record_Support_txt
=== RUN   TestAccRoute53Record_Support_spf
=== PAUSE TestAccRoute53Record_Support_spf
=== RUN   TestAccRoute53Record_Support_caa
=== PAUSE TestAccRoute53Record_Support_caa
=== RUN   TestAccRoute53Record_Support_ds
=== PAUSE TestAccRoute53Record_Support_ds
=== RUN   TestAccRoute53Record_generatesSuffix
=== PAUSE TestAccRoute53Record_generatesSuffix
=== RUN   TestAccRoute53Record_wildcard
=== PAUSE TestAccRoute53Record_wildcard
=== RUN   TestAccRoute53Record_failover
=== PAUSE TestAccRoute53Record_failover
=== RUN   TestAccRoute53Record_Weighted_basic
=== PAUSE TestAccRoute53Record_Weighted_basic
=== RUN   TestAccRoute53Record_WeightedToSimple_basic
=== PAUSE TestAccRoute53Record_WeightedToSimple_basic
=== RUN   TestAccRoute53Record_Alias_elb
=== PAUSE TestAccRoute53Record_Alias_elb
=== RUN   TestAccRoute53Record_Alias_s3
=== PAUSE TestAccRoute53Record_Alias_s3
=== RUN   TestAccRoute53Record_Alias_vpcEndpoint
=== PAUSE TestAccRoute53Record_Alias_vpcEndpoint
=== RUN   TestAccRoute53Record_Alias_uppercase
=== PAUSE TestAccRoute53Record_Alias_uppercase
=== RUN   TestAccRoute53Record_Weighted_alias
=== PAUSE TestAccRoute53Record_Weighted_alias
=== RUN   TestAccRoute53Record_cidr
=== PAUSE TestAccRoute53Record_cidr
=== RUN   TestAccRoute53Record_Geolocation_basic
=== PAUSE TestAccRoute53Record_Geolocation_basic
=== RUN   TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== PAUSE TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== RUN   TestAccRoute53Record_HealthCheckID_typeChange
=== PAUSE TestAccRoute53Record_HealthCheckID_typeChange
=== RUN   TestAccRoute53Record_Latency_basic
=== PAUSE TestAccRoute53Record_Latency_basic
=== RUN   TestAccRoute53Record_typeChange
=== PAUSE TestAccRoute53Record_typeChange
=== RUN   TestAccRoute53Record_nameChange
=== PAUSE TestAccRoute53Record_nameChange
=== RUN   TestAccRoute53Record_setIdentifierChangeBasicToWeighted
=== PAUSE TestAccRoute53Record_setIdentifierChangeBasicToWeighted
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationContinent
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationContinent
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
=== RUN   TestAccRoute53Record_SetIdentifierRename_failover
=== PAUSE TestAccRoute53Record_SetIdentifierRename_failover
=== RUN   TestAccRoute53Record_SetIdentifierRename_latency
=== PAUSE TestAccRoute53Record_SetIdentifierRename_latency
=== RUN   TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
=== PAUSE TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
=== RUN   TestAccRoute53Record_SetIdentifierRename_weighted
=== PAUSE TestAccRoute53Record_SetIdentifierRename_weighted
=== RUN   TestAccRoute53Record_Alias_change
=== PAUSE TestAccRoute53Record_Alias_change
=== RUN   TestAccRoute53Record_Alias_changeDualstack
=== PAUSE TestAccRoute53Record_Alias_changeDualstack
=== RUN   TestAccRoute53Record_empty
=== PAUSE TestAccRoute53Record_empty
=== RUN   TestAccRoute53Record_longTXTrecord
=== PAUSE TestAccRoute53Record_longTXTrecord
=== RUN   TestAccRoute53Record_MultiValueAnswer_basic
=== PAUSE TestAccRoute53Record_MultiValueAnswer_basic
=== RUN   TestAccRoute53Record_Allow_doNotOverwrite
=== PAUSE TestAccRoute53Record_Allow_doNotOverwrite
=== RUN   TestAccRoute53Record_Allow_overwrite
=== PAUSE TestAccRoute53Record_Allow_overwrite
=== CONT  TestAccRoute53Record_basic
=== CONT  TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== CONT  TestAccRoute53Record_wildcard
--- PASS: TestAccRoute53Record_basic (128.39s)
=== CONT  TestAccRoute53Record_Geolocation_basic
--- PASS: TestAccRoute53Record_wildcard (179.63s)
=== CONT  TestAccRoute53Record_cidr
--- PASS: TestAccRoute53Record_HealthCheckID_setIdentifierChange (186.43s)
=== CONT  TestAccRoute53Record_Weighted_alias
--- PASS: TestAccRoute53Record_Geolocation_basic (151.36s)
=== CONT  TestAccRoute53Record_Alias_uppercase
--- PASS: TestAccRoute53Record_Alias_uppercase (126.05s)
=== CONT  TestAccRoute53Record_Alias_vpcEndpoint
--- PASS: TestAccRoute53Record_cidr (249.16s)
=== CONT  TestAccRoute53Record_Alias_s3
--- PASS: TestAccRoute53Record_Weighted_alias (305.81s)
=== CONT  TestAccRoute53Record_Alias_elb
--- PASS: TestAccRoute53Record_Alias_s3 (152.72s)
=== CONT  TestAccRoute53Record_WeightedToSimple_basic
--- PASS: TestAccRoute53Record_Alias_elb (155.54s)
=== CONT  TestAccRoute53Record_Weighted_basic
--- PASS: TestAccRoute53Record_WeightedToSimple_basic (187.10s)
=== CONT  TestAccRoute53Record_failover
--- PASS: TestAccRoute53Record_Weighted_basic (144.20s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationContinent
--- PASS: TestAccRoute53Record_Alias_vpcEndpoint (398.52s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_failover
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
--- PASS: TestAccRoute53Record_failover (142.28s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationContinent (179.66s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
--- PASS: TestAccRoute53Record_SetIdentifierRename_failover (175.23s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision (172.98s)
=== CONT  TestAccRoute53Record_empty
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault (181.11s)
=== CONT  TestAccRoute53Record_Allow_overwrite
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified (226.42s)
=== CONT  TestAccRoute53Record_Allow_doNotOverwrite
--- PASS: TestAccRoute53Record_empty (146.72s)
=== CONT  TestAccRoute53Record_MultiValueAnswer_basic
--- PASS: TestAccRoute53Record_Allow_doNotOverwrite (135.39s)
=== CONT  TestAccRoute53Record_longTXTrecord
--- PASS: TestAccRoute53Record_Allow_overwrite (197.60s)
=== CONT  TestAccRoute53Record_typeChange
--- PASS: TestAccRoute53Record_MultiValueAnswer_basic (149.17s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_latency
=== CONT  TestAccRoute53Record_Alias_changeDualstack
--- PASS: TestAccRoute53Record_longTXTrecord (137.99s)
--- PASS: TestAccRoute53Record_typeChange (192.91s)
=== CONT  TestAccRoute53Record_Alias_change
--- PASS: TestAccRoute53Record_SetIdentifierRename_latency (210.42s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_weighted
--- PASS: TestAccRoute53Record_Alias_changeDualstack (181.19s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
--- PASS: TestAccRoute53Record_Alias_change (178.94s)
=== CONT  TestAccRoute53Record_setIdentifierChangeBasicToWeighted
--- PASS: TestAccRoute53Record_SetIdentifierRename_weighted (182.47s)
=== CONT  TestAccRoute53Record_nameChange
--- PASS: TestAccRoute53Record_SetIdentifierRename_multiValueAnswer (202.81s)
=== CONT  TestAccRoute53Record_Support_txt
--- PASS: TestAccRoute53Record_setIdentifierChangeBasicToWeighted (173.91s)
=== CONT  TestAccRoute53Record_generatesSuffix
--- PASS: TestAccRoute53Record_Support_txt (109.43s)
=== CONT  TestAccRoute53Record_Latency_basic
--- PASS: TestAccRoute53Record_nameChange (241.24s)
=== CONT  TestAccRoute53Record_Support_ds
--- PASS: TestAccRoute53Record_generatesSuffix (126.25s)
=== CONT  TestAccRoute53Record_Support_caa
--- PASS: TestAccRoute53Record_Latency_basic (159.30s)
=== CONT  TestAccRoute53Record_Support_spf
--- PASS: TestAccRoute53Record_Support_ds (136.82s)
=== CONT  TestAccRoute53Record_Disappears_multipleRecords
--- PASS: TestAccRoute53Record_Support_caa (135.73s)
=== CONT  TestAccRoute53Record_HealthCheckID_typeChange
--- PASS: TestAccRoute53Record_Support_spf (108.95s)
=== CONT  TestAccRoute53Record_trailingPeriodAndZoneID
--- PASS: TestAccRoute53Record_HealthCheckID_typeChange (181.53s)
=== CONT  TestAccRoute53Record_disappears
--- PASS: TestAccRoute53Record_Disappears_multipleRecords (206.90s)
=== CONT  TestAccRoute53Record_fqdn
--- PASS: TestAccRoute53Record_trailingPeriodAndZoneID (134.20s)
=== CONT  TestAccRoute53Record_underscored
--- PASS: TestAccRoute53Record_disappears (144.33s)
--- PASS: TestAccRoute53Record_fqdn (134.56s)
--- PASS: TestAccRoute53Record_underscored (127.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	2500.251s

@ewbankkit
r/aws_route53_cidr_collection: Add documentation.
492e6a5
@ewbankkit
r/aws_route53_cidr_collection: New resources.
ed15f33 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRoute53CIDRCollection_' PKG=route53 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 3  -run=TestAccRoute53CIDRCollection_ -timeout 180m
=== RUN   TestAccRoute53CIDRCollection_basic
=== PAUSE TestAccRoute53CIDRCollection_basic
=== RUN   TestAccRoute53CIDRCollection_disappears
=== PAUSE TestAccRoute53CIDRCollection_disappears
=== CONT  TestAccRoute53CIDRCollection_basic
=== CONT  TestAccRoute53CIDRCollection_disappears
--- PASS: TestAccRoute53CIDRCollection_disappears (11.97s)
--- PASS: TestAccRoute53CIDRCollection_basic (15.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	20.994s
@ewbankkit
r/aws_route53_cidr_collection: Add 'version' attribute.
40e7a13
@ewbankkit
r/aws_route53_cidr_location: Add documentation.
deb5912
@ewbankkit
Add types.CIDRBlock'.
5622afe
@ewbankkit
r/aws_route53_cidr_collection: Tidy up acceptance tests.
5d37983
@ewbankkit
r/aws_route53_cidr_location: New resources.
106ebe0 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRoute53CIDRLocation_' PKG=route53 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 3  -run=TestAccRoute53CIDRLocation_ -timeout 180m
=== RUN   TestAccRoute53CIDRLocation_basic
=== PAUSE TestAccRoute53CIDRLocation_basic
=== RUN   TestAccRoute53CIDRLocation_update
=== PAUSE TestAccRoute53CIDRLocation_update
=== CONT  TestAccRoute53CIDRLocation_basic
=== CONT  TestAccRoute53CIDRLocation_update
--- PASS: TestAccRoute53CIDRLocation_basic (16.99s)
--- PASS: TestAccRoute53CIDRLocation_update (26.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	31.705s
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. flex Pertains to FLatteners and EXpanders. service/route53 Issues and PRs that pertain to the route53 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Feb 14, 2023
@ewbankkit

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. labels Feb 14, 2023
@ewbankkit
r/aws_reoute53_record: Use 'validation.StringInSlice'.
33d523d
@ewbankkit
Route 53: Finder corrections.
c2a62e3
@ewbankkit
Acceptance test output:
aa0d302 
% make testacc TESTARGS='-run=TestAccRoute53Record_' PKG=route53 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 3  -run=TestAccRoute53Record_ -timeout 180m
=== RUN   TestAccRoute53Record_basic
=== PAUSE TestAccRoute53Record_basic
=== RUN   TestAccRoute53Record_underscored
=== PAUSE TestAccRoute53Record_underscored
=== RUN   TestAccRoute53Record_Disappears_basic
=== PAUSE TestAccRoute53Record_Disappears_basic
=== RUN   TestAccRoute53Record_Disappears_multipleRecords
=== PAUSE TestAccRoute53Record_Disappears_multipleRecords
=== RUN   TestAccRoute53Record_fqdn
=== PAUSE TestAccRoute53Record_fqdn
=== RUN   TestAccRoute53Record_trailingPeriodAndZoneID
=== PAUSE TestAccRoute53Record_trailingPeriodAndZoneID
=== RUN   TestAccRoute53Record_Support_txt
=== PAUSE TestAccRoute53Record_Support_txt
=== RUN   TestAccRoute53Record_Support_spf
=== PAUSE TestAccRoute53Record_Support_spf
=== RUN   TestAccRoute53Record_Support_caa
=== PAUSE TestAccRoute53Record_Support_caa
=== RUN   TestAccRoute53Record_Support_ds
=== PAUSE TestAccRoute53Record_Support_ds
=== RUN   TestAccRoute53Record_generatesSuffix
=== PAUSE TestAccRoute53Record_generatesSuffix
=== RUN   TestAccRoute53Record_wildcard
=== PAUSE TestAccRoute53Record_wildcard
=== RUN   TestAccRoute53Record_failover
=== PAUSE TestAccRoute53Record_failover
=== RUN   TestAccRoute53Record_Weighted_basic
=== PAUSE TestAccRoute53Record_Weighted_basic
=== RUN   TestAccRoute53Record_WeightedToSimple_basic
=== PAUSE TestAccRoute53Record_WeightedToSimple_basic
=== RUN   TestAccRoute53Record_Alias_elb
=== PAUSE TestAccRoute53Record_Alias_elb
=== RUN   TestAccRoute53Record_Alias_s3
=== PAUSE TestAccRoute53Record_Alias_s3
=== RUN   TestAccRoute53Record_Alias_vpcEndpoint
=== PAUSE TestAccRoute53Record_Alias_vpcEndpoint
=== RUN   TestAccRoute53Record_Alias_uppercase
=== PAUSE TestAccRoute53Record_Alias_uppercase
=== RUN   TestAccRoute53Record_Weighted_alias
=== PAUSE TestAccRoute53Record_Weighted_alias
=== RUN   TestAccRoute53Record_Geolocation_basic
=== PAUSE TestAccRoute53Record_Geolocation_basic
=== RUN   TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== PAUSE TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== RUN   TestAccRoute53Record_HealthCheckID_typeChange
=== PAUSE TestAccRoute53Record_HealthCheckID_typeChange
=== RUN   TestAccRoute53Record_Latency_basic
=== PAUSE TestAccRoute53Record_Latency_basic
=== RUN   TestAccRoute53Record_typeChange
=== PAUSE TestAccRoute53Record_typeChange
=== RUN   TestAccRoute53Record_nameChange
=== PAUSE TestAccRoute53Record_nameChange
=== RUN   TestAccRoute53Record_setIdentifierChangeBasicToWeighted
=== PAUSE TestAccRoute53Record_setIdentifierChangeBasicToWeighted
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationContinent
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationContinent
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
=== RUN   TestAccRoute53Record_SetIdentifierRename_failover
=== PAUSE TestAccRoute53Record_SetIdentifierRename_failover
=== RUN   TestAccRoute53Record_SetIdentifierRename_latency
=== PAUSE TestAccRoute53Record_SetIdentifierRename_latency
=== RUN   TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
=== PAUSE TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
=== RUN   TestAccRoute53Record_SetIdentifierRename_weighted
=== PAUSE TestAccRoute53Record_SetIdentifierRename_weighted
=== RUN   TestAccRoute53Record_Alias_change
=== PAUSE TestAccRoute53Record_Alias_change
=== RUN   TestAccRoute53Record_Alias_changeDualstack
=== PAUSE TestAccRoute53Record_Alias_changeDualstack
=== RUN   TestAccRoute53Record_empty
=== PAUSE TestAccRoute53Record_empty
=== RUN   TestAccRoute53Record_longTXTrecord
=== PAUSE TestAccRoute53Record_longTXTrecord
=== RUN   TestAccRoute53Record_MultiValueAnswer_basic
=== PAUSE TestAccRoute53Record_MultiValueAnswer_basic
=== RUN   TestAccRoute53Record_Allow_doNotOverwrite
=== PAUSE TestAccRoute53Record_Allow_doNotOverwrite
=== RUN   TestAccRoute53Record_Allow_overwrite
=== PAUSE TestAccRoute53Record_Allow_overwrite
=== CONT  TestAccRoute53Record_basic
=== CONT  TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== CONT  TestAccRoute53Record_wildcard
--- PASS: TestAccRoute53Record_basic (149.55s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_latency
--- PASS: TestAccRoute53Record_wildcard (210.52s)
=== CONT  TestAccRoute53Record_Allow_overwrite
--- PASS: TestAccRoute53Record_HealthCheckID_setIdentifierChange (228.55s)
=== CONT  TestAccRoute53Record_Allow_doNotOverwrite
--- PASS: TestAccRoute53Record_Allow_doNotOverwrite (110.89s)
=== CONT  TestAccRoute53Record_MultiValueAnswer_basic
--- PASS: TestAccRoute53Record_SetIdentifierRename_latency (197.22s)
=== CONT  TestAccRoute53Record_longTXTrecord
--- PASS: TestAccRoute53Record_Allow_overwrite (191.49s)
=== CONT  TestAccRoute53Record_empty
--- PASS: TestAccRoute53Record_longTXTrecord (115.92s)
=== CONT  TestAccRoute53Record_Alias_changeDualstack
--- PASS: TestAccRoute53Record_MultiValueAnswer_basic (139.92s)
=== CONT  TestAccRoute53Record_Alias_change
--- PASS: TestAccRoute53Record_empty (97.20s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_weighted
--- PASS: TestAccRoute53Record_Alias_changeDualstack (181.11s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
--- PASS: TestAccRoute53Record_Alias_change (201.84s)
=== CONT  TestAccRoute53Record_Support_txt
--- PASS: TestAccRoute53Record_SetIdentifierRename_weighted (206.73s)
=== CONT  TestAccRoute53Record_generatesSuffix
--- PASS: TestAccRoute53Record_Support_txt (144.83s)
=== CONT  TestAccRoute53Record_Support_ds
--- PASS: TestAccRoute53Record_generatesSuffix (132.80s)
=== CONT  TestAccRoute53Record_Support_caa
--- PASS: TestAccRoute53Record_SetIdentifierRename_multiValueAnswer (205.46s)
=== CONT  TestAccRoute53Record_Support_spf
--- PASS: TestAccRoute53Record_Support_ds (131.61s)
=== CONT  TestAccRoute53Record_Disappears_multipleRecords
--- PASS: TestAccRoute53Record_Support_caa (150.29s)
=== CONT  TestAccRoute53Record_trailingPeriodAndZoneID
--- PASS: TestAccRoute53Record_Support_spf (145.37s)
=== CONT  TestAccRoute53Record_fqdn
--- PASS: TestAccRoute53Record_trailingPeriodAndZoneID (151.32s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationContinent
--- PASS: TestAccRoute53Record_Disappears_multipleRecords (182.99s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_failover
--- PASS: TestAccRoute53Record_fqdn (157.83s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationContinent (179.44s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision (177.76s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
--- PASS: TestAccRoute53Record_SetIdentifierRename_failover (194.83s)
=== CONT  TestAccRoute53Record_Alias_s3
--- PASS: TestAccRoute53Record_Alias_s3 (140.86s)
=== CONT  TestAccRoute53Record_Geolocation_basic
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault (169.46s)
=== CONT  TestAccRoute53Record_Weighted_alias
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified (188.84s)
=== CONT  TestAccRoute53Record_Alias_uppercase
--- PASS: TestAccRoute53Record_Geolocation_basic (139.59s)
=== CONT  TestAccRoute53Record_Alias_vpcEndpoint
--- PASS: TestAccRoute53Record_Alias_uppercase (142.79s)
=== CONT  TestAccRoute53Record_Disappears_basic
--- PASS: TestAccRoute53Record_Weighted_alias (278.90s)
=== CONT  TestAccRoute53Record_underscored
--- PASS: TestAccRoute53Record_Disappears_basic (137.76s)
=== CONT  TestAccRoute53Record_WeightedToSimple_basic
--- PASS: TestAccRoute53Record_underscored (132.39s)
=== CONT  TestAccRoute53Record_Alias_elb
--- PASS: TestAccRoute53Record_WeightedToSimple_basic (160.70s)
=== CONT  TestAccRoute53Record_typeChange
--- PASS: TestAccRoute53Record_Alias_vpcEndpoint (355.82s)
=== CONT  TestAccRoute53Record_setIdentifierChangeBasicToWeighted
--- PASS: TestAccRoute53Record_Alias_elb (136.01s)
=== CONT  TestAccRoute53Record_nameChange
--- PASS: TestAccRoute53Record_typeChange (177.66s)
=== CONT  TestAccRoute53Record_Latency_basic
--- PASS: TestAccRoute53Record_setIdentifierChangeBasicToWeighted (174.49s)
=== CONT  TestAccRoute53Record_HealthCheckID_typeChange
--- PASS: TestAccRoute53Record_Latency_basic (151.18s)
=== CONT  TestAccRoute53Record_Weighted_basic
--- PASS: TestAccRoute53Record_nameChange (251.97s)
=== CONT  TestAccRoute53Record_failover
--- PASS: TestAccRoute53Record_HealthCheckID_typeChange (200.78s)
--- PASS: TestAccRoute53Record_Weighted_basic (160.12s)
--- PASS: TestAccRoute53Record_failover (157.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	2465.691s
@ewbankkit
Fix golangci-lint 'whitespace'.
88f0ac1
@ewbankkit
Rename 'ChangeRecordSet' to 'ChangeResourceRecordSets'.
32e35b1
@ewbankkit
r/aws_route53_record: Add 'cidr_routing_policy' attribute.
a6cdc58
@ewbankkit
r/aws_route53_route: Start testing 'cidr_routing_policy' attribute.
5a03290 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRoute53Record_basic\|TestAccRoute53Record_disappears\|TestAccRoute53Record_Disappears_' PKG=route53 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 3  -run=TestAccRoute53Record_basic\|TestAccRoute53Record_disappears\|TestAccRoute53Record_Disappears_ -timeout 180m
=== RUN   TestAccRoute53Record_basic
=== PAUSE TestAccRoute53Record_basic
=== RUN   TestAccRoute53Record_disappears
=== PAUSE TestAccRoute53Record_disappears
=== RUN   TestAccRoute53Record_Disappears_multipleRecords
=== PAUSE TestAccRoute53Record_Disappears_multipleRecords
=== CONT  TestAccRoute53Record_basic
=== CONT  TestAccRoute53Record_Disappears_multipleRecords
=== CONT  TestAccRoute53Record_disappears
--- PASS: TestAccRoute53Record_disappears (140.73s)
--- PASS: TestAccRoute53Record_basic (156.27s)
--- PASS: TestAccRoute53Record_Disappears_multipleRecords (202.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	207.883s
@ewbankkit
r/aws_route53_route: Testing 'cidr_routing_policy' attribute.
3aa13b5 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRoute53Record_' PKG=route53 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 3  -run=TestAccRoute53Record_ -timeout 180m
=== RUN   TestAccRoute53Record_basic
=== PAUSE TestAccRoute53Record_basic
=== RUN   TestAccRoute53Record_disappears
=== PAUSE TestAccRoute53Record_disappears
=== RUN   TestAccRoute53Record_Disappears_multipleRecords
=== PAUSE TestAccRoute53Record_Disappears_multipleRecords
=== RUN   TestAccRoute53Record_underscored
=== PAUSE TestAccRoute53Record_underscored
=== RUN   TestAccRoute53Record_fqdn
=== PAUSE TestAccRoute53Record_fqdn
=== RUN   TestAccRoute53Record_trailingPeriodAndZoneID
=== PAUSE TestAccRoute53Record_trailingPeriodAndZoneID
=== RUN   TestAccRoute53Record_Support_txt
=== PAUSE TestAccRoute53Record_Support_txt
=== RUN   TestAccRoute53Record_Support_spf
=== PAUSE TestAccRoute53Record_Support_spf
=== RUN   TestAccRoute53Record_Support_caa
=== PAUSE TestAccRoute53Record_Support_caa
=== RUN   TestAccRoute53Record_Support_ds
=== PAUSE TestAccRoute53Record_Support_ds
=== RUN   TestAccRoute53Record_generatesSuffix
=== PAUSE TestAccRoute53Record_generatesSuffix
=== RUN   TestAccRoute53Record_wildcard
=== PAUSE TestAccRoute53Record_wildcard
=== RUN   TestAccRoute53Record_failover
=== PAUSE TestAccRoute53Record_failover
=== RUN   TestAccRoute53Record_Weighted_basic
=== PAUSE TestAccRoute53Record_Weighted_basic
=== RUN   TestAccRoute53Record_WeightedToSimple_basic
=== PAUSE TestAccRoute53Record_WeightedToSimple_basic
=== RUN   TestAccRoute53Record_Alias_elb
=== PAUSE TestAccRoute53Record_Alias_elb
=== RUN   TestAccRoute53Record_Alias_s3
=== PAUSE TestAccRoute53Record_Alias_s3
=== RUN   TestAccRoute53Record_Alias_vpcEndpoint
=== PAUSE TestAccRoute53Record_Alias_vpcEndpoint
=== RUN   TestAccRoute53Record_Alias_uppercase
=== PAUSE TestAccRoute53Record_Alias_uppercase
=== RUN   TestAccRoute53Record_Weighted_alias
=== PAUSE TestAccRoute53Record_Weighted_alias
=== RUN   TestAccRoute53Record_cidr
=== PAUSE TestAccRoute53Record_cidr
=== RUN   TestAccRoute53Record_Geolocation_basic
=== PAUSE TestAccRoute53Record_Geolocation_basic
=== RUN   TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== PAUSE TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== RUN   TestAccRoute53Record_HealthCheckID_typeChange
=== PAUSE TestAccRoute53Record_HealthCheckID_typeChange
=== RUN   TestAccRoute53Record_Latency_basic
=== PAUSE TestAccRoute53Record_Latency_basic
=== RUN   TestAccRoute53Record_typeChange
=== PAUSE TestAccRoute53Record_typeChange
=== RUN   TestAccRoute53Record_nameChange
=== PAUSE TestAccRoute53Record_nameChange
=== RUN   TestAccRoute53Record_setIdentifierChangeBasicToWeighted
=== PAUSE TestAccRoute53Record_setIdentifierChangeBasicToWeighted
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationContinent
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationContinent
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
=== RUN   TestAccRoute53Record_SetIdentifierRename_failover
=== PAUSE TestAccRoute53Record_SetIdentifierRename_failover
=== RUN   TestAccRoute53Record_SetIdentifierRename_latency
=== PAUSE TestAccRoute53Record_SetIdentifierRename_latency
=== RUN   TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
=== PAUSE TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
=== RUN   TestAccRoute53Record_SetIdentifierRename_weighted
=== PAUSE TestAccRoute53Record_SetIdentifierRename_weighted
=== RUN   TestAccRoute53Record_Alias_change
=== PAUSE TestAccRoute53Record_Alias_change
=== RUN   TestAccRoute53Record_Alias_changeDualstack
=== PAUSE TestAccRoute53Record_Alias_changeDualstack
=== RUN   TestAccRoute53Record_empty
=== PAUSE TestAccRoute53Record_empty
=== RUN   TestAccRoute53Record_longTXTrecord
=== PAUSE TestAccRoute53Record_longTXTrecord
=== RUN   TestAccRoute53Record_MultiValueAnswer_basic
=== PAUSE TestAccRoute53Record_MultiValueAnswer_basic
=== RUN   TestAccRoute53Record_Allow_doNotOverwrite
=== PAUSE TestAccRoute53Record_Allow_doNotOverwrite
=== RUN   TestAccRoute53Record_Allow_overwrite
=== PAUSE TestAccRoute53Record_Allow_overwrite
=== CONT  TestAccRoute53Record_basic
=== CONT  TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== CONT  TestAccRoute53Record_wildcard
--- PASS: TestAccRoute53Record_basic (107.84s)
=== CONT  TestAccRoute53Record_Geolocation_basic
--- PASS: TestAccRoute53Record_wildcard (175.13s)
=== CONT  TestAccRoute53Record_cidr
--- PASS: TestAccRoute53Record_HealthCheckID_setIdentifierChange (255.89s)
=== CONT  TestAccRoute53Record_Weighted_alias
--- PASS: TestAccRoute53Record_Geolocation_basic (152.56s)
=== CONT  TestAccRoute53Record_Alias_uppercase
--- PASS: TestAccRoute53Record_Alias_uppercase (134.94s)
=== CONT  TestAccRoute53Record_Alias_s3
--- PASS: TestAccRoute53Record_Alias_vpcEndpoint (481.69s)
--- PASS: TestAccRoute53Record_cidr (230.87s)
=== CONT  TestAccRoute53Record_Alias_elb
--- PASS: TestAccRoute53Record_Alias_s3 (137.70s)
=== CONT  TestAccRoute53Record_WeightedToSimple_basic
--- PASS: TestAccRoute53Record_Weighted_alias (296.11s)
=== CONT  TestAccRoute53Record_Weighted_basic
--- PASS: TestAccRoute53Record_Alias_elb (159.10s)
=== CONT  TestAccRoute53Record_failover
--- PASS: TestAccRoute53Record_Weighted_basic (125.81s)
=== CONT  TestAccRoute53Record_underscored
--- PASS: TestAccRoute53Record_failover (149.10s)
=== CONT  TestAccRoute53Record_trailingPeriodAndZoneID
--- PASS: TestAccRoute53Record_WeightedToSimple_basic (199.94s)
=== CONT  TestAccRoute53Record_fqdn
--- PASS: TestAccRoute53Record_underscored (143.84s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_latency
--- PASS: TestAccRoute53Record_trailingPeriodAndZoneID (133.76s)
=== CONT  TestAccRoute53Record_Allow_overwrite
--- PASS: TestAccRoute53Record_fqdn (147.86s)
=== CONT  TestAccRoute53Record_Allow_doNotOverwrite
--- PASS: TestAccRoute53Record_Allow_doNotOverwrite (122.12s)
=== CONT  TestAccRoute53Record_MultiValueAnswer_basic
--- PASS: TestAccRoute53Record_Allow_overwrite (170.96s)
=== CONT  TestAccRoute53Record_longTXTrecord
--- PASS: TestAccRoute53Record_SetIdentifierRename_latency (202.35s)
=== CONT  TestAccRoute53Record_empty
--- PASS: TestAccRoute53Record_MultiValueAnswer_basic (153.91s)
=== CONT  TestAccRoute53Record_Alias_changeDualstack
--- PASS: TestAccRoute53Record_longTXTrecord (139.40s)
=== CONT  TestAccRoute53Record_Alias_change
--- PASS: TestAccRoute53Record_empty (139.66s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_weighted
--- PASS: TestAccRoute53Record_Alias_change (166.40s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
--- PASS: TestAccRoute53Record_Alias_changeDualstack (190.10s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationContinent
--- PASS: TestAccRoute53Record_SetIdentifierRename_weighted (184.97s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_failover
--- PASS: TestAccRoute53Record_SetIdentifierRename_multiValueAnswer (176.88s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
--- PASS: TestAccRoute53Record_SetIdentifierRename_failover (178.31s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationContinent (183.02s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision (185.45s)
=== CONT  TestAccRoute53Record_Support_txt
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified (183.11s)
=== CONT  TestAccRoute53Record_Support_ds
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault (195.23s)
=== CONT  TestAccRoute53Record_Support_caa
--- PASS: TestAccRoute53Record_Support_txt (100.12s)
=== CONT  TestAccRoute53Record_generatesSuffix
--- PASS: TestAccRoute53Record_Support_ds (131.19s)
=== CONT  TestAccRoute53Record_Support_spf
--- PASS: TestAccRoute53Record_Support_caa (123.04s)
=== CONT  TestAccRoute53Record_typeChange
--- PASS: TestAccRoute53Record_generatesSuffix (125.71s)
=== CONT  TestAccRoute53Record_setIdentifierChangeBasicToWeighted
--- PASS: TestAccRoute53Record_Support_spf (123.86s)
=== CONT  TestAccRoute53Record_Latency_basic
--- PASS: TestAccRoute53Record_typeChange (159.89s)
=== CONT  TestAccRoute53Record_Disappears_multipleRecords
--- PASS: TestAccRoute53Record_setIdentifierChangeBasicToWeighted (192.43s)
=== CONT  TestAccRoute53Record_nameChange
--- PASS: TestAccRoute53Record_Latency_basic (156.11s)
=== CONT  TestAccRoute53Record_disappears
--- PASS: TestAccRoute53Record_Disappears_multipleRecords (202.12s)
=== CONT  TestAccRoute53Record_HealthCheckID_typeChange
--- PASS: TestAccRoute53Record_disappears (162.93s)
=== CONT  TestAccRoute53Record_nameChange
    testing_new.go:84: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: deleting Route53 Hosted Zone (Z0325593GP0N3DAV6PVU): HostedZoneNotEmpty: The specified hosted zone contains non-required resource record sets  and so cannot be deleted.
        	status code: 400, request id: a7b10bc1-89a3-4c76-bc27-407541fb9ea2

--- FAIL: TestAccRoute53Record_nameChange (283.97s)
--- PASS: TestAccRoute53Record_HealthCheckID_typeChange (344.79s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/route53	2561.609s
@ewbankkit
r/aws_route53_record: Fix delete when changing name.
250768e
@ewbankkit ewbankkit marked this pull request as ready for review February 15, 2023 22:42
@ewbankkit ewbankkit merged commit 30b1b2e into main Feb 15, 2023
@ewbankkit ewbankkit deleted the f-route53-cidr-collection branch February 15, 2023 23:34
@github-actions github-actions bot added this to the v4.55.0 milestone Feb 15, 2023
github-actions bot pushed a commit that referenced this pull request Feb 15, 2023
Update CHANGELOG.md for #29407
28b7a41
@github-actions
Copy link

This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. flex Pertains to FLatteners and EXpanders. github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/route53 Issues and PRs that pertain to the route53 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.55.0
Development

Successfully merging this pull request may close these issues.

Add support for Route 53 IP Based Routing Policy
1 participant
@ewbankkit