Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_servicecatalog_provisioned_product: outputs refresh when resource updates #29559

Merged
merged 5 commits into from
Feb 22, 2023

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Feb 22, 2023

Description

Adds customdiff to set outputs to Computed when the resource is updated.

Relations

Closes #29560

References

Output from Acceptance Testing

$ make testacc PKG=servicecatalog TESTS="TestAccServiceCatalogProvisionedProduct_"

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogProvisionedProduct_'  -timeout 180m
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (129.52s)
--- PASS: TestAccServiceCatalogProvisionedProduct_basic (133.23s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tainted (203.67s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (219.68s)
--- PASS: TestAccServiceCatalogProvisionedProduct_update (221.18s)
--- PASS: TestAccServiceCatalogProvisionedProduct_computedOutputs (247.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	250.859s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/servicecatalog Issues and PRs that pertain to the servicecatalog service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Feb 22, 2023
@johnsonaj johnsonaj added the bug Addresses a defect in current functionality. label Feb 22, 2023
@johnsonaj johnsonaj marked this pull request as ready for review February 22, 2023 02:38
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=servicecatalog TESTS="TestAccServiceCatalogProvisionedProduct_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogProvisionedProduct_'  -timeout 180m
=== RUN   TestAccServiceCatalogProvisionedProduct_basic
=== PAUSE TestAccServiceCatalogProvisionedProduct_basic
=== RUN   TestAccServiceCatalogProvisionedProduct_update
=== PAUSE TestAccServiceCatalogProvisionedProduct_update
=== RUN   TestAccServiceCatalogProvisionedProduct_computedOutputs
=== PAUSE TestAccServiceCatalogProvisionedProduct_computedOutputs
=== RUN   TestAccServiceCatalogProvisionedProduct_disappears
=== PAUSE TestAccServiceCatalogProvisionedProduct_disappears
=== RUN   TestAccServiceCatalogProvisionedProduct_tags
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags
=== RUN   TestAccServiceCatalogProvisionedProduct_tainted
=== PAUSE TestAccServiceCatalogProvisionedProduct_tainted
=== CONT  TestAccServiceCatalogProvisionedProduct_basic
=== CONT  TestAccServiceCatalogProvisionedProduct_disappears
=== CONT  TestAccServiceCatalogProvisionedProduct_computedOutputs
=== CONT  TestAccServiceCatalogProvisionedProduct_update
=== CONT  TestAccServiceCatalogProvisionedProduct_tainted
=== CONT  TestAccServiceCatalogProvisionedProduct_tags
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (131.56s)
--- PASS: TestAccServiceCatalogProvisionedProduct_basic (135.29s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tainted (205.79s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (222.10s)
--- PASS: TestAccServiceCatalogProvisionedProduct_update (225.21s)
--- PASS: TestAccServiceCatalogProvisionedProduct_computedOutputs (242.75s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog     245.889s

@johnsonaj johnsonaj force-pushed the b-aws_servicecatalog_provisioned_product branch from 7727328 to 74403b7 Compare February 22, 2023 16:49
@johnsonaj johnsonaj merged commit 0a2fe0f into main Feb 22, 2023
@johnsonaj johnsonaj deleted the b-aws_servicecatalog_provisioned_product branch February 22, 2023 17:23
@github-actions github-actions bot added this to the v4.56.0 milestone Feb 22, 2023
github-actions bot pushed a commit that referenced this pull request Feb 22, 2023
@github-actions
Copy link

This functionality has been released in v4.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: aws_servicecatalog_provisioned_product: outputs attribute does not update
2 participants