-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding resource - OAM Sink #29670
Adding resource - OAM Sink #29670
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccObservabilityAccessManagerSink_' PKG=oam ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/oam/... -v -count 1 -parallel 3 -run=TestAccObservabilityAccessManagerSink_ -timeout 180m
=== RUN TestAccObservabilityAccessManagerSink_basic
--- PASS: TestAccObservabilityAccessManagerSink_basic (21.90s)
=== RUN TestAccObservabilityAccessManagerSink_disappears
--- PASS: TestAccObservabilityAccessManagerSink_disappears (15.33s)
=== RUN TestAccObservabilityAccessManagerSink_tags
--- PASS: TestAccObservabilityAccessManagerSink_tags (48.06s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/oam 93.729s
@royrajan13 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add support for CloudWatch Observability Access Manager Sink Resource. Use this to create a sink the account, so that it can be used as a monitoring account in CloudWatch cross-account observability.
Relations
Relates #28158
Output from Acceptance Testing