Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: aws_ecs_task_execution #29783

Merged
merged 4 commits into from
Mar 7, 2023
Merged

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Mar 3, 2023

Description

The aws_ecs_task_execution data source will enable use cases when a one-time task needs to run on an existing ECS cluster.

As this data source wraps the RunTask API, it will provision tasks on every read operation where the input attributes are known. This may include terraform plan commands, and should be used with caution for any tasks that cannot safely run multiple instances in parallel.

Relations

Adapted from #12096
Closes #1703

References

This data source was modeled after aws_lambda_function_invocation.

Output from Acceptance Testing

$ make testacc PKG=ecs TESTS=TestAccECSTaskExecutionDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSTaskExecutionDataSource_'  -timeout 180m
=== RUN   TestAccECSTaskExecutionDataSource_basic
=== PAUSE TestAccECSTaskExecutionDataSource_basic
=== RUN   TestAccECSTaskExecutionDataSource_tags
=== PAUSE TestAccECSTaskExecutionDataSource_tags
=== CONT  TestAccECSTaskExecutionDataSource_basic
=== CONT  TestAccECSTaskExecutionDataSource_tags
--- PASS: TestAccECSTaskExecutionDataSource_basic (310.88s)
--- PASS: TestAccECSTaskExecutionDataSource_tags (310.89s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        313.941s

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecs Issues and PRs that pertain to the ecs service. generators Relates to code generators. labels Mar 3, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 3, 2023
@jar-b jar-b marked this pull request as ready for review March 3, 2023 21:22
@ewbankkit ewbankkit added the new-data-source Introduces a new data source. label Mar 7, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECSTaskExecutionDataSource_' PKG=ecs ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 1  -run=TestAccECSTaskExecutionDataSource_ -timeout 180m
=== RUN   TestAccECSTaskExecutionDataSource_basic
=== PAUSE TestAccECSTaskExecutionDataSource_basic
=== RUN   TestAccECSTaskExecutionDataSource_tags
=== PAUSE TestAccECSTaskExecutionDataSource_tags
=== CONT  TestAccECSTaskExecutionDataSource_basic
--- PASS: TestAccECSTaskExecutionDataSource_basic (287.35s)
=== CONT  TestAccECSTaskExecutionDataSource_tags
--- PASS: TestAccECSTaskExecutionDataSource_tags (321.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	615.013s

@jar-b jar-b merged commit eef7cba into main Mar 7, 2023
@jar-b jar-b deleted the f-aws_ecs_task_execution branch March 7, 2023 15:18
@github-actions github-actions bot added this to the v4.58.0 milestone Mar 7, 2023
@bryantbiggs
Copy link
Contributor

Thanks for the addition! A question around the execution during a plan, or any read operation. How difficult would it be to implement something similar to the null_resources triggers which would allow for this to be a resource that is only executed once until a trigger is changed? Executing on read I suspect is going to raise a lot of issues - just wondering if the functionality used in the null resource could be adapted for these one off type resources until a user wants to re-run again

@SyntaxColoring
Copy link
Contributor

SyntaxColoring commented Mar 8, 2023

Or, instead of adding a triggers argument, perhaps rely on the standard replace_triggered_by argument.

@bryantbiggs
Copy link
Contributor

can move the convo over to new issue since this thread will get locked tomorrow once the new release goes out

@github-actions
Copy link

This functionality has been released in v4.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/ecs Issues and PRs that pertain to the ecs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: aws_ecs_runtask
4 participants