-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with include_fec attribute not being set #29808
Conversation
Hey @quartercastle 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.) |
Community NoteVoting for Prioritization
For Submitters
|
e6651da
to
a9e799c
Compare
The organisation i'm contributing from doesn't allow this. |
a9e799c
to
29bbc43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the PR looks good! I made one suggestion on the test name. Also, can you merge or rebase main
into this PR. A few dependencies have been merged since this was originally opened.
include_fec in fec_output_settings are not set correctly
Co-authored-by: Adrian Johnson <adrian.johnson@hashicorp.com>
bc0e72e
to
aaf0c94
Compare
@johnsonaj, thanks for the review. I have rebased main into the PR so it should be up to date again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
$ make testacc TESTS=TestAccMediaLiveChannel_ PKG=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_' -timeout 180m
--- PASS: TestAccMediaLiveChannel_audioDescriptions_codecSettings (83.22s)
--- PASS: TestAccMediaLiveChannel_hls (88.04s)
--- PASS: TestAccMediaLiveChannel_disappears (97.24s)
--- PASS: TestAccMediaLiveChannel_basic (98.69s)
--- PASS: TestAccMediaLiveChannel_update (117.86s)
--- PASS: TestAccMediaLiveChannel_UDP_outputSettings (168.15s)
--- PASS: TestAccMediaLiveChannel_m2ts_settings (173.71s)
--- PASS: TestAccMediaLiveChannel_updateTags (173.87s)
--- PASS: TestAccMediaLiveChannel_status (221.26s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/medialive 224.210s
@quartercastle thanks for the contribution! 🎉 |
This functionality has been released in v4.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
The
include_fec
attribute infec_output_settings
wasn't set correctly.Relations
Relates #27824
References
Output from Acceptance Testing