-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disable cross zone load balancing option to target group #29920
Add disable cross zone load balancing option to target group #29920
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccELBV2TargetGroup_Stickiness_updateAppEnabled\|TestAccELBV2TargetGroupDataSource_basic\|TestAccELBV2TargetGroupDataSource_tags\|TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled\|TestAccELBV2TargetGroup_ProtocolVersion_basic' PKG=elbv2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 3 -run=TestAccELBV2TargetGroup_Stickiness_updateAppEnabled\|TestAccELBV2TargetGroupDataSource_basic\|TestAccELBV2TargetGroupDataSource_tags\|TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled\|TestAccELBV2TargetGroup_ProtocolVersion_basic -timeout 180m
=== RUN TestAccELBV2TargetGroupDataSource_basic
=== PAUSE TestAccELBV2TargetGroupDataSource_basic
=== RUN TestAccELBV2TargetGroupDataSource_tags
=== PAUSE TestAccELBV2TargetGroupDataSource_tags
=== RUN TestAccELBV2TargetGroup_ProtocolVersion_basic
=== PAUSE TestAccELBV2TargetGroup_ProtocolVersion_basic
=== RUN TestAccELBV2TargetGroup_Stickiness_updateAppEnabled
=== PAUSE TestAccELBV2TargetGroup_Stickiness_updateAppEnabled
=== RUN TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled
=== CONT TestAccELBV2TargetGroupDataSource_basic
=== CONT TestAccELBV2TargetGroup_Stickiness_updateAppEnabled
=== CONT TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled
--- PASS: TestAccELBV2TargetGroup_Stickiness_updateAppEnabled (50.48s)
=== CONT TestAccELBV2TargetGroup_ProtocolVersion_basic
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled (50.48s)
=== CONT TestAccELBV2TargetGroupDataSource_tags
--- PASS: TestAccELBV2TargetGroupDataSource_tags (18.44s)
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_basic (35.06s)
--- PASS: TestAccELBV2TargetGroupDataSource_basic (169.01s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elbv2 174.628s
@teru01 Thanks for the contribution 🎉 👏. |
6f81efa
to
26940ab
Compare
This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
add
load_balancing_cross_zone_enabled
option to aws_lb_target_groupRelations
Closes #28041
References
Output from Acceptance Testing