Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resource emr_block_public_access_configuration #29968

Conversation

lentonwork
Copy link
Contributor

Description

This PR adds an emr_block_public_access_configuration resource.

The decision has been made to run serialised tests due to the fact that only a single EMR block public access configuration can be defined for a configured AWS account and region.

The 'Update' function has been omitted in favour of configuring each argument to force replacement of the resource. There is no AWS API call that supports 'updating' the configuration, only replacing it.

The template 'Test...Exists' test has been omitted, as it is impossible not to have an EMR Block Public Access
Configuration for a configured account and region. Instead, test functions have been designed to check the attributes of the current EMR Block Public Access Configuration and validate them against expected values.

Relations

Closes #26215

References

AWS EMR Block Public Access Configuration Documentation.

AWS EMR Go Package Documentation

Output from Acceptance Testing

$ make testacc TESTS=TestAccEMRBlockPublicAccessConfiguration PKG=emr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20 -run='TestAccEMRBlockPublicAccessConfiguration'  -timeout 180m
=== RUN   TestAccEMRBlockPublicAccessConfiguration_basic
--- PASS: TestAccEMRBlockPublicAccessConfiguration_basic (30.12s)
=== RUN   TestAccEMRBlockPublicAccessConfiguration_disappears
--- PASS: TestAccEMRBlockPublicAccessConfiguration_disappears (15.85s)
=== RUN   TestAccEMRBlockPublicAccessConfiguration_default
--- PASS: TestAccEMRBlockPublicAccessConfiguration_default (15.33s)
=== RUN   TestAccEMRBlockPublicAccessConfiguration_enabledMultiRange
--- PASS: TestAccEMRBlockPublicAccessConfiguration_enabledMultiRange (15.55s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/emr        79.698s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/emr Issues and PRs that pertain to the emr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/emr Issues and PRs that pertain to the emr service. generators Relates to code generators. labels Mar 13, 2023
@lentonwork lentonwork force-pushed the f-aws_emr_block_public_access_configuration branch from a0bd475 to 3ee48af Compare March 13, 2023 13:55
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/emr Issues and PRs that pertain to the emr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 13, 2023
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 14, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEMRBlockPublicAccessConfiguration_' PKG=emr ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 3  -run=TestAccEMRBlockPublicAccessConfiguration_ -timeout 180m
=== RUN   TestAccEMRBlockPublicAccessConfiguration_basic
--- PASS: TestAccEMRBlockPublicAccessConfiguration_basic (39.95s)
=== RUN   TestAccEMRBlockPublicAccessConfiguration_disappears
--- PASS: TestAccEMRBlockPublicAccessConfiguration_disappears (21.41s)
=== RUN   TestAccEMRBlockPublicAccessConfiguration_default
--- PASS: TestAccEMRBlockPublicAccessConfiguration_default (20.54s)
=== RUN   TestAccEMRBlockPublicAccessConfiguration_enabledMultiRange
--- PASS: TestAccEMRBlockPublicAccessConfiguration_enabledMultiRange (20.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	111.487s

@ewbankkit
Copy link
Contributor

@lentonwork Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 322095f into hashicorp:main Mar 15, 2023
@github-actions github-actions bot added this to the v4.59.0 milestone Mar 15, 2023
@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/emr Issues and PRs that pertain to the emr service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add support for EMR Public Block Access
2 participants