-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add resource emr_block_public_access_configuration #29968
add resource emr_block_public_access_configuration #29968
Conversation
Community NoteVoting for Prioritization
For Submitters
|
a0bd475
to
3ee48af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEMRBlockPublicAccessConfiguration_' PKG=emr ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 3 -run=TestAccEMRBlockPublicAccessConfiguration_ -timeout 180m
=== RUN TestAccEMRBlockPublicAccessConfiguration_basic
--- PASS: TestAccEMRBlockPublicAccessConfiguration_basic (39.95s)
=== RUN TestAccEMRBlockPublicAccessConfiguration_disappears
--- PASS: TestAccEMRBlockPublicAccessConfiguration_disappears (21.41s)
=== RUN TestAccEMRBlockPublicAccessConfiguration_default
--- PASS: TestAccEMRBlockPublicAccessConfiguration_default (20.54s)
=== RUN TestAccEMRBlockPublicAccessConfiguration_enabledMultiRange
--- PASS: TestAccEMRBlockPublicAccessConfiguration_enabledMultiRange (20.69s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/emr 111.487s
@lentonwork Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds an
emr_block_public_access_configuration
resource.The decision has been made to run serialised tests due to the fact that only a single EMR block public access configuration can be defined for a configured AWS account and region.
The 'Update' function has been omitted in favour of configuring each argument to force replacement of the resource. There is no AWS API call that supports 'updating' the configuration, only replacing it.
The template 'Test...Exists' test has been omitted, as it is impossible not to have an EMR Block Public Access
Configuration for a configured account and region. Instead, test functions have been designed to check the attributes of the current EMR Block Public Access Configuration and validate them against expected values.
Relations
Closes #26215
References
AWS EMR Block Public Access Configuration Documentation.
AWS EMR Go Package Documentation
Output from Acceptance Testing