Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_cognito_risk_configuration: validation for risk_exception_configuration #30074

Merged
merged 6 commits into from
Mar 17, 2023

Conversation

gdavison
Copy link
Contributor

Description

Adds validation to the risk_exception_configuration parameter

Relations

Closes #29508

References

Output from Acceptance Testing

$ make testacc PKG=cognitoidp TESTS=TestAccCognitoIDPRiskConfiguration_

--- PASS: TestAccCognitoIDPRiskConfiguration_nullRiskException (2.70s)
--- PASS: TestAccCognitoIDPRiskConfiguration_emptyRiskException (2.84s)
--- PASS: TestAccCognitoIDPRiskConfiguration_empty (2.88s)
--- PASS: TestAccCognitoIDPRiskConfiguration_disappears_userPool (11.73s)
--- PASS: TestAccCognitoIDPRiskConfiguration_disappears (13.28s)
--- PASS: TestAccCognitoIDPRiskConfiguration_compromised (14.71s)
--- PASS: TestAccCognitoIDPRiskConfiguration_client (15.09s)
--- PASS: TestAccCognitoIDPRiskConfiguration_exception (22.43s)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. labels Mar 16, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCognitoIDPRiskConfiguration_' PKG=cognitoidp ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 2  -run=TestAccCognitoIDPRiskConfiguration_ -timeout 180m
=== RUN   TestAccCognitoIDPRiskConfiguration_exception
=== PAUSE TestAccCognitoIDPRiskConfiguration_exception
=== RUN   TestAccCognitoIDPRiskConfiguration_client
=== PAUSE TestAccCognitoIDPRiskConfiguration_client
=== RUN   TestAccCognitoIDPRiskConfiguration_compromised
=== PAUSE TestAccCognitoIDPRiskConfiguration_compromised
=== RUN   TestAccCognitoIDPRiskConfiguration_disappears
=== PAUSE TestAccCognitoIDPRiskConfiguration_disappears
=== RUN   TestAccCognitoIDPRiskConfiguration_disappears_userPool
=== PAUSE TestAccCognitoIDPRiskConfiguration_disappears_userPool
=== RUN   TestAccCognitoIDPRiskConfiguration_empty
=== PAUSE TestAccCognitoIDPRiskConfiguration_empty
=== RUN   TestAccCognitoIDPRiskConfiguration_nullRiskException
=== PAUSE TestAccCognitoIDPRiskConfiguration_nullRiskException
=== RUN   TestAccCognitoIDPRiskConfiguration_emptyRiskException
=== PAUSE TestAccCognitoIDPRiskConfiguration_emptyRiskException
=== CONT  TestAccCognitoIDPRiskConfiguration_exception
=== CONT  TestAccCognitoIDPRiskConfiguration_disappears_userPool
--- PASS: TestAccCognitoIDPRiskConfiguration_disappears_userPool (14.47s)
=== CONT  TestAccCognitoIDPRiskConfiguration_compromised
--- PASS: TestAccCognitoIDPRiskConfiguration_exception (35.77s)
=== CONT  TestAccCognitoIDPRiskConfiguration_disappears
--- PASS: TestAccCognitoIDPRiskConfiguration_compromised (21.54s)
=== CONT  TestAccCognitoIDPRiskConfiguration_client
--- PASS: TestAccCognitoIDPRiskConfiguration_disappears (18.22s)
=== CONT  TestAccCognitoIDPRiskConfiguration_nullRiskException
--- PASS: TestAccCognitoIDPRiskConfiguration_nullRiskException (1.66s)
=== CONT  TestAccCognitoIDPRiskConfiguration_emptyRiskException
--- PASS: TestAccCognitoIDPRiskConfiguration_emptyRiskException (1.56s)
=== CONT  TestAccCognitoIDPRiskConfiguration_empty
--- PASS: TestAccCognitoIDPRiskConfiguration_client (22.11s)
--- PASS: TestAccCognitoIDPRiskConfiguration_empty (1.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	63.838s

@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. labels Mar 17, 2023
@ewbankkit
Copy link
Contributor

Needs a CHANGELOG entry.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 17, 2023
@gdavison gdavison merged commit 51cd1a1 into main Mar 17, 2023
@gdavison gdavison deleted the b-cognito-riskconfiguration branch March 17, 2023 18:02
@github-actions github-actions bot added this to the v4.60.0 milestone Mar 17, 2023
github-actions bot pushed a commit that referenced this pull request Mar 17, 2023
@github-actions
Copy link

This functionality has been released in v4.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error: Plugin did not respond
2 participants