Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support IceBerg File Format in aws_sagemaker_feature_group #30098

Closed
lsamaha1-chwy opened this issue Mar 17, 2023 · 3 comments · Fixed by #30118
Closed

[Enhancement]: Support IceBerg File Format in aws_sagemaker_feature_group #30098

lsamaha1-chwy opened this issue Mar 17, 2023 · 3 comments · Fixed by #30118
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Milestone

Comments

@lsamaha1-chwy
Copy link

lsamaha1-chwy commented Mar 17, 2023

Description

Requesting that Terraform add support for IceBerg format for SageMaker offline FeatureStore. SageMaker Feature Store added support for creating FeatureGroups with offline storage in iceberg format 12/2022 (announced here). Docs are (here). Examples of usage are here.

Affected Resource(s) and/or Data Source(s)

aws_sagemaker_feature_group

Potential Terraform Configuration

resource "aws_sagemaker_feature_group" "customer_feature_group" {
  feature_group_name             = "fg1"
  record_identifier_feature_name = "customer_id"
  event_time_feature_name        = "at"
  role_arn                       = aws_iam_role.feature_group_role.arn
  feature_definition {
    feature_name = "customer_id"
    feature_type = "String"
  } ...
  offline_store_config {
    s3_storage_config {
      kms_key_id = var.kms_key_arn
      s3_uri = "s3://${var.s3_bucket}/fs/data"
    }
    table_format: "Iceberg"
  } ...
}

References

No response

Would you like to implement a fix?

None

@lsamaha1-chwy lsamaha1-chwy added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Mar 17, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/sagemaker Issues and PRs that pertain to the sagemaker service. label Mar 17, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Mar 17, 2023
@DrFaust92 DrFaust92 self-assigned this Mar 18, 2023
@github-actions github-actions bot added this to the v4.62.0 milestone Mar 31, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants