Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added IPv6 support to Route53 Resolver Endpoint and Forward rule #30167

Merged
merged 9 commits into from
Oct 9, 2024

Conversation

tamiros
Copy link
Contributor

@tamiros tamiros commented Mar 21, 2023

Description

This PR adds:

  • resolver_endpoint_type attribute to the aws_route53_resolver_endpoint resource.
  • ipv6 attribute to the target_ip struct of the aws_route53_resolver_rule resource.

Relations

Closes #30075

References

https://aws.amazon.com/about-aws/whats-new/2023/03/amazon-route-53-resolver-endpoints-hybrid-cloud-ipv6-support/

Output from Acceptance Testing

make testacc TESTS='TestAccRoute53ResolverEndpoint_basic_ipv6' PKG=route53resolver
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverEndpoint_basic_ipv6'  -timeout 180m
=== RUN   TestAccRoute53ResolverEndpoint_basic_ipv6
=== PAUSE TestAccRoute53ResolverEndpoint_basic_ipv6
=== CONT  TestAccRoute53ResolverEndpoint_basic_ipv6
--- PASS: TestAccRoute53ResolverEndpoint_basic_ipv6 (97.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    97.337s

...
make testacc TESTS='TestAccRoute53ResolverRule_forward_ipv6' PKG=route53resolver TESTARGS=-short ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 1 -run='TestAccRoute53ResolverRule_forward_ipv6' -short -timeout 180m
=== RUN   TestAccRoute53ResolverRule_forward_ipv6
=== PAUSE TestAccRoute53ResolverRule_forward_ipv6
=== CONT  TestAccRoute53ResolverRule_forward_ipv6
--- PASS: TestAccRoute53ResolverRule_forward_ipv6 (317.99s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    318.072s

...
make testacc TESTS='TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6' PKG=route53resolver TESTARGS=-short ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 1 -run='TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6' -short -timeout 180m
=== RUN   TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6
=== PAUSE TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6
=== CONT  TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6
--- PASS: TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6 (432.61s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    432.698s


@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/route53resolver Issues and PRs that pertain to the route53resolver service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 21, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @tamiros 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@tamiros tamiros marked this pull request as draft April 4, 2023 08:53
@tamiros tamiros force-pushed the f-route53resolver-ipv6-supp-30075 branch from 5f3b6cd to 4792680 Compare April 4, 2023 09:11
@tamiros tamiros marked this pull request as ready for review April 4, 2023 09:12
@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 6, 2023
@kongdewen
Copy link

Is there any targeted release date for this?

@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 7, 2024
@nam054 nam054 requested a review from a team as a code owner October 9, 2024 17:21
Copy link
Contributor

@nam054 nam054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for your contribution!

> make testacc TESTARGS="-run=TestAccRoute53ResolverEndpoint_" PKG=route53resolver
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/route53resolver/... -v -count 1 -parallel 20  -run=TestAccRoute53ResolverEndpoint_ -timeout 360m
=== RUN   TestAccRoute53ResolverEndpoint_basic
=== PAUSE TestAccRoute53ResolverEndpoint_basic
=== RUN   TestAccRoute53ResolverEndpoint_basic_ipv6
=== PAUSE TestAccRoute53ResolverEndpoint_basic_ipv6
=== RUN   TestAccRoute53ResolverEndpoint_disappears
=== PAUSE TestAccRoute53ResolverEndpoint_disappears
=== RUN   TestAccRoute53ResolverEndpoint_tags
=== PAUSE TestAccRoute53ResolverEndpoint_tags
=== RUN   TestAccRoute53ResolverEndpoint_updateOutbound
=== PAUSE TestAccRoute53ResolverEndpoint_updateOutbound
=== RUN   TestAccRoute53ResolverEndpoint_resolverEndpointType
=== PAUSE TestAccRoute53ResolverEndpoint_resolverEndpointType
=== CONT  TestAccRoute53ResolverEndpoint_basic
=== CONT  TestAccRoute53ResolverEndpoint_tags
=== CONT  TestAccRoute53ResolverEndpoint_disappears
=== CONT  TestAccRoute53ResolverEndpoint_resolverEndpointType
=== CONT  TestAccRoute53ResolverEndpoint_basic_ipv6
=== CONT  TestAccRoute53ResolverEndpoint_updateOutbound
--- PASS: TestAccRoute53ResolverEndpoint_basic_ipv6 (94.22s)
--- PASS: TestAccRoute53ResolverEndpoint_disappears (102.04s)
--- PASS: TestAccRoute53ResolverEndpoint_basic (104.56s)
--- PASS: TestAccRoute53ResolverEndpoint_tags (127.51s)
--- PASS: TestAccRoute53ResolverEndpoint_resolverEndpointType (157.03s)
--- PASS: TestAccRoute53ResolverEndpoint_updateOutbound (330.72s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    336.070s
> make testacc TESTARGS="-run=TestAccRoute53ResolverRule_" PKG=route53resolver
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/route53resolver/... -v -count 1 -parallel 20  -run=TestAccRoute53ResolverRule_ -timeout 360m
=== RUN   TestAccRoute53ResolverRule_basic
=== PAUSE TestAccRoute53ResolverRule_basic
=== RUN   TestAccRoute53ResolverRule_disappears
=== PAUSE TestAccRoute53ResolverRule_disappears
=== RUN   TestAccRoute53ResolverRule_tags
=== PAUSE TestAccRoute53ResolverRule_tags
=== RUN   TestAccRoute53ResolverRule_justDotDomainName
=== PAUSE TestAccRoute53ResolverRule_justDotDomainName
=== RUN   TestAccRoute53ResolverRule_trailingDotDomainName
=== PAUSE TestAccRoute53ResolverRule_trailingDotDomainName
=== RUN   TestAccRoute53ResolverRule_updateName
=== PAUSE TestAccRoute53ResolverRule_updateName
=== RUN   TestAccRoute53ResolverRule_forward
=== PAUSE TestAccRoute53ResolverRule_forward
=== RUN   TestAccRoute53ResolverRule_forwardMultiProtocol
=== PAUSE TestAccRoute53ResolverRule_forwardMultiProtocol
=== RUN   TestAccRoute53ResolverRule_forward_ipv6
=== PAUSE TestAccRoute53ResolverRule_forward_ipv6
=== RUN   TestAccRoute53ResolverRule_forwardEndpointRecreate
=== PAUSE TestAccRoute53ResolverRule_forwardEndpointRecreate
=== RUN   TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6
=== PAUSE TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6
=== CONT  TestAccRoute53ResolverRule_basic
=== CONT  TestAccRoute53ResolverRule_justDotDomainName
=== CONT  TestAccRoute53ResolverRule_forward
=== CONT  TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6
=== CONT  TestAccRoute53ResolverRule_forwardEndpointRecreate
=== CONT  TestAccRoute53ResolverRule_forward_ipv6
=== CONT  TestAccRoute53ResolverRule_forwardMultiProtocol
=== CONT  TestAccRoute53ResolverRule_updateName
=== CONT  TestAccRoute53ResolverRule_trailingDotDomainName
=== CONT  TestAccRoute53ResolverRule_tags
=== CONT  TestAccRoute53ResolverRule_disappears
--- PASS: TestAccRoute53ResolverRule_disappears (17.11s)
--- PASS: TestAccRoute53ResolverRule_justDotDomainName (19.80s)
--- PASS: TestAccRoute53ResolverRule_trailingDotDomainName (19.81s)
--- PASS: TestAccRoute53ResolverRule_basic (19.88s)
--- PASS: TestAccRoute53ResolverRule_updateName (27.56s)
--- PASS: TestAccRoute53ResolverRule_tags (34.85s)
--- PASS: TestAccRoute53ResolverRule_forward (230.40s)
--- PASS: TestAccRoute53ResolverRule_forwardMultiProtocol (240.15s)
--- PASS: TestAccRoute53ResolverRule_forward_ipv6 (261.12s)
--- PASS: TestAccRoute53ResolverRule_forwardEndpointRecreate_ipv6 (430.82s)
--- PASS: TestAccRoute53ResolverRule_forwardEndpointRecreate (449.31s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    454.450s

@nam054 nam054 merged commit 6c7dd89 into hashicorp:main Oct 9, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.71.0 milestone Oct 9, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 15, 2024
Copy link

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add IPv6 option to aws_route53_resolver_rule
4 participants