Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_quicksight_data_set #30349

Merged
merged 78 commits into from
Mar 31, 2023
Merged

New Resource: aws_quicksight_data_set #30349

merged 78 commits into from
Mar 31, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Mar 30, 2023

Description

This PR adds the aws_quicksight_data_set resource, allowing practitioners to manage Quicksight data sets via Terraform. This will also enable development of additional Quicksight resources dependent on data sets.

This PR was built on #21971, and moved here due to missing maintainer edit permissions on the underlying fork.

Relations

Supersedes #21971
Relates #10990
Closes #21101

References

Output from Acceptance Testing

$ make testacc PKG=quicksight TESTS=TestAccQuickSightDataSet_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightDataSet_'  -timeout 180m

--- PASS: TestAccQuickSightDataSet_disappears (30.56s)
--- PASS: TestAccQuickSightDataSet_columnLevelPermissionRules (34.06s)
--- PASS: TestAccQuickSightDataSet_tags (34.26s)
--- PASS: TestAccQuickSightDataSet_logicalTableMap (34.75s)
--- PASS: TestAccQuickSightDataSet_rowLevelPermissionTagConfiguration (34.96s)
--- PASS: TestAccQuickSightDataSet_columnGroups (35.09s)
--- PASS: TestAccQuickSightDataSet_fieldFolders (35.28s)
--- PASS: TestAccQuickSightDataSet_basic (35.30s)
--- PASS: TestAccQuickSightDataSet_dataSetUsageConfiguration (35.31s)
--- PASS: TestAccQuickSightDataSet_permissions (73.46s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 76.738s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/quicksight Issues and PRs that pertain to the quicksight service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 30, 2023
@jar-b jar-b marked this pull request as ready for review March 30, 2023 18:43
@jar-b jar-b merged commit 9e81586 into main Mar 31, 2023
@jar-b jar-b deleted the f-aws_quicksight_data_set branch March 31, 2023 14:36
@github-actions github-actions bot added this to the v4.62.0 milestone Mar 31, 2023
github-actions bot pushed a commit that referenced this pull request Mar 31, 2023
@jar-b
Copy link
Member Author

jar-b commented Mar 31, 2023

Thanks for your contribution, @lacernetic! 👏

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/quicksight Issues and PRs that pertain to the quicksight service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional QuickSight resource: aws_quicksight_data_set
2 participants