-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SecurityHub Account Configuration #30692
Conversation
Community NoteVoting for Prioritization
For Submitters
|
- Update API call for hub configuration read - Add support to configure whether to enable new controls automatically - Add support for Security Hub consolidated control findings Fixes hashicorp#30022
adc0004
to
4779b1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSecurityHub_serial/^Account$$' PKG=securityhub
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/securityhub/... -v -count 1 -parallel 20 -run=TestAccSecurityHub_serial/^Account$ -timeout 180m
=== RUN TestAccSecurityHub_serial
=== PAUSE TestAccSecurityHub_serial
=== CONT TestAccSecurityHub_serial
=== RUN TestAccSecurityHub_serial/Account
=== RUN TestAccSecurityHub_serial/Account/disappears
=== RUN TestAccSecurityHub_serial/Account/EnableDefaultStandardsFalse
=== RUN TestAccSecurityHub_serial/Account/MigrateV0
=== RUN TestAccSecurityHub_serial/Account/full
=== RUN TestAccSecurityHub_serial/Account/basic
--- PASS: TestAccSecurityHub_serial (125.53s)
--- PASS: TestAccSecurityHub_serial/Account (125.53s)
--- PASS: TestAccSecurityHub_serial/Account/disappears (12.44s)
--- PASS: TestAccSecurityHub_serial/Account/EnableDefaultStandardsFalse (13.16s)
--- PASS: TestAccSecurityHub_serial/Account/MigrateV0 (59.74s)
--- PASS: TestAccSecurityHub_serial/Account/full (24.65s)
--- PASS: TestAccSecurityHub_serial/Account/basic (15.54s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/securityhub 131.014s
@lawliet89 Thanks for the contribution 🎉 👏. |
This is a follow up to hashicorp#30692 Fixes a typo introduced in that PR
This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #30022.
Closes #30748.
References
Output from Acceptance Testing