Fix: Principal allowed returned multiple when expecting one

[robh007]

Description

A change was made to vpc_endpoint_service_allowed #27640 which introduced tfresource.AssertSingleResult however the results returned from the call to FindVPCEndpointServicePermissions didn't filter the result & anything above 1 allowed principal resulted in an error. I've also added an additional test which adds two service principals to be allowed access to the endpoint.

Relations

Closes #30873.
Relates #27640.

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccVPCEndpointServiceAllowedPrincipal_multiple PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointServiceAllowedPrincipal_multiple'  -timeout 180m
=== RUN   TestAccVPCEndpointServiceAllowedPrincipal_multiple
=== PAUSE TestAccVPCEndpointServiceAllowedPrincipal_multiple
=== CONT  TestAccVPCEndpointServiceAllowedPrincipal_multiple
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_multiple (270.01s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        274.270s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCEndpointServiceAllowedPrincipal_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCEndpointServiceAllowedPrincipal_ -timeout 180m
=== RUN   TestAccVPCEndpointServiceAllowedPrincipal_basic
=== PAUSE TestAccVPCEndpointServiceAllowedPrincipal_basic
=== RUN   TestAccVPCEndpointServiceAllowedPrincipal_multiple
=== PAUSE TestAccVPCEndpointServiceAllowedPrincipal_multiple
=== RUN   TestAccVPCEndpointServiceAllowedPrincipal_tags
=== PAUSE TestAccVPCEndpointServiceAllowedPrincipal_tags
=== RUN   TestAccVPCEndpointServiceAllowedPrincipal_migrateID
=== PAUSE TestAccVPCEndpointServiceAllowedPrincipal_migrateID
=== RUN   TestAccVPCEndpointServiceAllowedPrincipal_migrateAndTag
=== PAUSE TestAccVPCEndpointServiceAllowedPrincipal_migrateAndTag
=== CONT  TestAccVPCEndpointServiceAllowedPrincipal_basic
=== CONT  TestAccVPCEndpointServiceAllowedPrincipal_migrateID
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_basic (236.85s)
=== CONT  TestAccVPCEndpointServiceAllowedPrincipal_migrateAndTag
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_migrateID (291.36s)
=== CONT  TestAccVPCEndpointServiceAllowedPrincipal_tags
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_tags (244.29s)
=== CONT  TestAccVPCEndpointServiceAllowedPrincipal_multiple
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_migrateAndTag (320.34s)
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_multiple (224.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	765.454s

[ewbankkit]

@robh007 Thanks for the contribution 🎉 👏.

I found that we have to do the principalARN filter client-side as we were getting errors like

An error occurred (InvalidFilter) when calling the DescribeVpcEndpointServicePermissions operation: The filter value arn:aws:iam::123456789012:role/terraform_team1_dev-developer contains unsupported characters

in our testing.

[robh007]

Thanks for fixing it up @ewbankkit , apologies if I caused additional work.

[github-actions]

This functionality has been released in v4.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.