-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeout to aws_redshiftserverless_workgroup #31054
Add timeout to aws_redshiftserverless_workgroup #31054
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @PatrickRice-KSC 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixed 1 issue I found doing a self-review where the Also, rebasing branch just to stay up-to-date :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRedshiftServerlessWorkgroup_basic$$' PKG=redshiftserverless
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshiftserverless/... -v -count 1 -parallel 20 -run=TestAccRedshiftServerlessWorkgroup_basic$ -timeout 180m
=== RUN TestAccRedshiftServerlessWorkgroup_basic
=== PAUSE TestAccRedshiftServerlessWorkgroup_basic
=== CONT TestAccRedshiftServerlessWorkgroup_basic
--- PASS: TestAccRedshiftServerlessWorkgroup_basic (529.40s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless 534.770s
@PatrickRice-KSC Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This pull request adds support to define the
timeouts
block within theaws_redshiftserverless_workgroup
resource. It also updates the default timeout from 10 Minutes to 20 Minutes to align to default terraform resource timeout behaviors.Relations
Closes #31048
References
Output from Acceptance Testing
Since the timeout doesn't modify the logic of the resource inherently, a
timeouts
block was added to the basic test to ensure that removal of the timeout logic would break thebasic
test.