Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon MSK multi-VPC private connectivity and cross-account access #31062

Closed
ewbankkit opened this issue Apr 28, 2023 · 9 comments · Fixed by #32848
Closed

Amazon MSK multi-VPC private connectivity and cross-account access #31062

ewbankkit opened this issue Apr 28, 2023 · 9 comments · Fixed by #32848
Assignees
Labels
new-resource Introduces a new resource. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/kafka Issues and PRs that pertain to the kafka service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Apr 28, 2023

Amazon MSK now offers multi-VPC private connectivity and cross-account access.

Announcement.
Blog post.

New Resources

  • aws_msk_vpc_connection
  • aws_msk_cluster_policy

Requires AWS SDK for Go v1.44.252: #31028.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@ewbankkit ewbankkit added new-resource Introduces a new resource. service/kafka Issues and PRs that pertain to the kafka service. labels Apr 28, 2023
@universalvishwa
Copy link

I'm so looking forward to this feature. Thank you.

@jmengoni
Copy link

Those changes have been implemented in awscc:

It seems to match the current implementation of the AWS provider, so wouldn't it be better to follow this solution rather than to create a new aws_msk_cluster_policy?

@universalvishwa
Copy link

We will need to create a new resource for that as per my experiments. Because ability to set the resource policy for MSK cluster only enabled (in the AWS console and AWS CLI) after I enabled multi-VPC connectivity in the cluster.
It would be good if someone can verify what I noticed when I was experimenting on this.

Also why can't they implement it on normal TF aws provider instead of this awscc provider? Is there a specific reason for doing it like this?

@markoskandylis
Copy link
Contributor

Hi, i will start working with this, this week

@breathingdust breathingdust added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 26, 2023
@kp-tom-sc
Copy link

It would be good if someone can verify what I noticed when I was experimenting on this.

This is my experience as well, you have to start by setting things to false, and then enabling them.

@vishwa-trulioo
Copy link

@ewbankkit Thank you very much for getting the aws_msk_vpc_connection resource and the respective updates on aws_msk_cluster in 5.12.0 release. Looking forward to the aws_msk_cluster_policy resource soon. You rock!

@github-actions github-actions bot added this to the v5.13.0 milestone Aug 11, 2023
@github-actions
Copy link

This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/kafka Issues and PRs that pertain to the kafka service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants