[Bug]: Data source aws_networkfirewall_firewall_policy fails if an override action is configured

[dancorne]

Terraform Core Version

1.4.6

AWS Provider Version

4.65.0

Affected Resource(s)

• data.aws_networkfirewall_firewall_policy

Expected Behavior

Return data about a network firewall policy, even when a managed rule group override is present

Actual Behavior

An error is raised and the plan/apply fails

Relevant Error/Panic Output Snippet

╷
│ Error: setting firewall_policy: Invalid address to set: []string{"stateful_rule_group_reference", "0", "override"}
│
│   with data.aws_networkfirewall_firewall_policy.test,
│   on main.tf line 17, in data "aws_networkfirewall_firewall_policy" "test":
│   17: data "aws_networkfirewall_firewall_policy" "test" {
│
╵

Terraform Configuration Files

resource "aws_networkfirewall_firewall_policy" "test" {
  name = "example"

  firewall_policy {
    stateless_default_actions          = ["aws:forward_to_sfe"]
    stateless_fragment_default_actions = ["aws:forward_to_sfe"]

    stateful_rule_group_reference {
      resource_arn = "arn:aws:network-firewall:eu-west-1:aws-managed:stateful-rulegroup/MalwareDomainsActionOrder"
      override {
        action = "DROP_TO_ALERT"
      }
    }
  }
}

data "aws_networkfirewall_firewall_policy" "test" {
  name = aws_networkfirewall_firewall_policy.test.name
}

Steps to Reproduce

Using the above configuration, a terraform apply will fail. It'll succeed if the override block is removed.

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

Yes

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[github-actions]

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.