Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_instance: Remove cpu_core_count and cpu_threads_per_core #31165

Open
ewbankkit opened this issue May 4, 2023 · 2 comments · May be fixed by #31263
Open

r/aws_instance: Remove cpu_core_count and cpu_threads_per_core #31165

ewbankkit opened this issue May 4, 2023 · 2 comments · May be fixed by #31263
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone
v6.0.0

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented May 4, 2023 •
edited
Loading

#31035 deprecated the cpu_core_count and cpu_threads_per_core attributes for v5.0.0 of the Terraform AWS Provider.
Remove the attribute in a future version.
@github-actions
Copy link

github-actions bot commented May 4, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@ewbankkit ewbankkit changed the title r/aws_instance: Remove cpu_core_count and cpu_threads_per_core r/aws_instance: Remove cpu_core_count and cpu_threads_per_core May 4, 2023
@ewbankkit ewbankkit added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/ec2 Issues and PRs that pertain to the ec2 service. labels May 4, 2023
@ewbankkit ewbankkit added this to the v6.0.0 milestone May 4, 2023
@krishnaduttPanchagnula krishnaduttPanchagnula linked a pull request May 8, 2023 that will close this issue
Open
@krishnaduttPanchagnula
Copy link

krishnaduttPanchagnula commented May 8, 2023 •
edited
Loading

Hi @ewbankkit I have raised a PR,please mention if there are more changes to be done. Also i wanted to update the .changelog but was unable to understand how to number the .txt file. Can you please help or point to document, how you in this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging a pull request may close this issue.

removed cpu_core_count and cpu_threads_per_core krishnaduttPanchagnula/terraform-provider-aws
2 participants
@ewbankkit @krishnaduttPanchagnula