Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_ssm_parameter: add "description" #3120

Closed
ghost opened this issue Jan 24, 2018 · 5 comments
Closed

aws_ssm_parameter: add "description" #3120

ghost opened this issue Jan 24, 2018 · 5 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/ssm Issues and PRs that pertain to the ssm service.
Milestone

Comments

@ghost
Copy link

ghost commented Jan 24, 2018

This issue was originally opened by @awuetz as hashicorp/terraform#17177. It was migrated here as a result of the provider split. The original body of the issue is below.


Hello hashicorp,

this is a feature request, to extend the aws ssm_parameter resource by the argument "description".
AWS is offering the possibility to add a description to the ssm parameter's. This should also be possible in terraform.

resource "aws_ssm_parameter" "secret" {
  name  = "${var.environment}/database/password/master"
  type  = "SecureString"
  value = "${var.database_master_password}"
  description = "This is my parameter"
}

Kind regards
Alex

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. labels Jan 24, 2018
@Puneeth-n
Copy link
Contributor

I looked at it. Unfortunately, the GetParameters AWS call in the Read function here doesn't return the description.

@ASVincent
Copy link

The Description field is available in the DescribeParameters AWS call, you can use it with (cli) --filter Key=Name,Values=key_name

It'd add an additional API request though.

See https://docs.aws.amazon.com/sdk-for-go/api/service/ssm/#SSM.DescribeParameters.

@Puneeth-n
Copy link
Contributor

@ASVincent Yea figured it :) Forgot to update here.

@Ninir Ninir added the easy label Mar 2, 2018
@paultyng paultyng added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. help wanted and removed good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. help wanted labels Mar 5, 2018
@bflad bflad added this to the v1.11.0 milestone Mar 15, 2018
@bflad
Copy link
Contributor

bflad commented Mar 15, 2018

Hi everyone! 👋 Looks like this issue was missed when we merged some enhancements for aws_ssm_parameter into master via #1520. As of v1.11.0 of the AWS provider, the aws_ssm_parameter resource now supports allowed_pattern, description, and tags arguments, as well as updating key_id. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@bflad bflad closed this as completed Mar 15, 2018
@ghost
Copy link
Author

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/ssm Issues and PRs that pertain to the ssm service.
Projects
None yet
Development

No branches or pull requests

5 participants