[Enhancement]: aws_network_acl better error message for duplicate NACL

[Nuru]

Description

AWS VPC subnets may only have a single Network ACL (NACL) associated with them, so of course it is appropriate to generate an error when you try to associate a second one. However, the error message is confusing:

Error: creating EC2 Network ACL: creating EC2 Network ACL (acl-XXXXXXXXXXXXXXXXX) Association: InvalidAssociationID.NotFound: The association ID 'aclassoc-XXXXXXXXXXXXXXXXX' does not exist

See #12152 for reproduction.

I am requesting a better error message, along the lines of

Error: creating EC2 Network ACL Association: Subnet 'subnet-XXXXXXXXXXXXXXXXX' already has Network ACL Association ID 'aclassoc-XXXXXXXXXXXXXXXXX' associating it with EC2 Network ACL 'acl-XXXXXXXXXXXXXXXXX'.

Affected Resource(s) and/or Data Source(s)

• aws_network_acl

Potential Terraform Configuration

No response

References

• Update NACL Subnet Association Returns Error - InvalidAssociationID.NotFound #12922
• aws_network_acl: creating multiple with count fails #12152
• resource/aws_network_acl: Fix issue where updating nacl subnet assoca… #13382

Would you like to implement a fix?

No

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[DhruvinSoni30]

Agree! A better error message is needed!