Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: aws_verifiedpermissions_policy_store #32204

Merged
merged 15 commits into from
Jan 5, 2024

Conversation

nolotz
Copy link
Contributor

@nolotz nolotz commented Jun 24, 2023

Description

This merge request is an extension to our ongoing efforts to support Amazon's VerifiedPermissions service in the Terraform AWS provider. The aim here is to include the aws_verifiedpermissions_policy_store resource, which provides users with the ability to manage their VerifiedPermissions policy stores directly through Terraform.

This merge request includes:

  • new terraform resource
  • tests
  • documentation
  • generated files
  • release note

Relations

Relates #32198
Relates #32158

Potential Terraform Configuration

resource "aws_verifiedpermissions_policy_store" "test" {
	validation_settings {
		mode = ""
	}
	schema {
		cedar_json = ""
	}
}

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccVerifiedPermissionsPolicyStore PKG=verifiedpermissions

TF_ACC=1 go test ./internal/service/verifiedpermissions/... -v -count 1 -parallel 20 -run='TestAccVerifiedPermissionsPolicyStore'  -timeout 180m
=== RUN   TestAccVerifiedPermissionsPolicyStore_basic
=== PAUSE TestAccVerifiedPermissionsPolicyStore_basic
=== RUN   TestAccVerifiedPermissionsPolicyStore_disappears
=== PAUSE TestAccVerifiedPermissionsPolicyStore_disappears
=== CONT  TestAccVerifiedPermissionsPolicyStore_basic
=== CONT  TestAccVerifiedPermissionsPolicyStore_disappears
--- PASS: TestAccVerifiedPermissionsPolicyStore_disappears (48.24s)
--- PASS: TestAccVerifiedPermissionsPolicyStore_basic (128.89s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/verifiedpermissions        132.299s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@nolotz nolotz mentioned this pull request Jun 24, 2023
7 tasks
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. needs-triage Waiting for first response or review from a maintainer. labels Jun 24, 2023
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 25, 2023
@nolotz
Copy link
Contributor Author

nolotz commented Jun 25, 2023

Requires #32198

@nolotz nolotz marked this pull request as ready for review June 25, 2023 02:53
@nolotz nolotz force-pushed the temp branch 3 times, most recently from 3c5afea to fa42497 Compare June 25, 2023 03:53
@nolotz nolotz marked this pull request as draft June 25, 2023 13:24
@nolotz nolotz marked this pull request as ready for review June 25, 2023 16:45
@nolotz nolotz force-pushed the temp branch 2 times, most recently from bf5ff0c to 40640b5 Compare June 25, 2023 18:16
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 26, 2023
@Pigius
Copy link

Pigius commented Jun 28, 2023

I would like to somehow to help @nolotz , but I have no much experience in Terraform 😓

@johnsonaj johnsonaj added the service/verifiedpermissions Issues and PRs that pertain to the verifiedpermissions service. label Jul 11, 2023
@luisordaz-ibotta
Copy link

hi! is there a roadmap/timeline for the merging of this new resource?

thanks!

@mrkresnofatih
Copy link

Are there any updates on this? Is it waiting on this PR #32208 ?
Would love to know how close this is from being released.

Thanks

@Pigius
Copy link

Pigius commented Aug 18, 2023

Any update on that @nolotz ? Maybe we can help?

@luisordaz-ibotta
Copy link

Any update on that @nolotz ? Maybe we can help?

+1

@johnsonaj johnsonaj self-assigned this Jan 4, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 4, 2024
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccVerifiedPermissions' PKG=verifiedpermissions

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/verifiedpermissions/... -v -count 1 -parallel 20  -run=TestAccVerifiedPermissions -timeout 360m
--- PASS: TestAccVerifiedPermissionsPolicyStoreDataSource_basic (12.09s)
--- PASS: TestAccVerifiedPermissionsPolicyStore_disappears (12.41s)
--- PASS: TestAccVerifiedPermissionsPolicyStore_basic (14.53s)
--- PASS: TestAccVerifiedPermissionsSchema_disappears (14.62s)
--- PASS: TestAccVerifiedPermissionsPolicyStore_update (18.17s)
--- PASS: TestAccVerifiedPermissionsSchema_basic (18.92s)
--- PASS: TestAccVerifiedPermissionsSchema_update (23.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/verifiedpermissions	27.059s

@johnsonaj
Copy link
Contributor

@nolotz thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 9f0e1bc into hashicorp:main Jan 5, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Jan 5, 2024
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/verifiedpermissions Issues and PRs that pertain to the verifiedpermissions service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants