Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F create aws open search vpc endpoint #32435

Merged
merged 51 commits into from
Aug 16, 2023

Conversation

lafod
Copy link
Contributor

@lafod lafod commented Jul 10, 2023

Description

This new resource allows you to access AWS Open search domain via a VPC Endpoint. These endpoints create a private connection between your VPC and Amazon OpenSearch Service.

Relations

Closes #29912

References

https://docs.aws.amazon.com/opensearch-service/latest/developerguide/vpc-interface-endpoints.html
https://aws.amazon.com/blogs/big-data/simplify-private-network-access-for-solutions-using-amazon-opensearch-service-managed-vpc-endpoints/

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAccOpenSearchVPCEndpoint_' PKG=opensearch ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 3  -run=TestAccOpenSearchVPCEndpoint_ -timeout 180m
=== RUN   TestAccOpenSearchVPCEndpoint_basic
=== PAUSE TestAccOpenSearchVPCEndpoint_basic
=== RUN   TestAccOpenSearchVPCEndpoint_update
=== PAUSE TestAccOpenSearchVPCEndpoint_update
=== RUN   TestAccOpenSearchVPCEndpoint_disappears
=== PAUSE TestAccOpenSearchVPCEndpoint_disappears
=== CONT  TestAccOpenSearchVPCEndpoint_basic
=== CONT  TestAccOpenSearchVPCEndpoint_update
=== CONT  TestAccOpenSearchVPCEndpoint_disappears
--- PASS: TestAccOpenSearchVPCEndpoint_basic (2348.70s)
--- PASS: TestAccOpenSearchVPCEndpoint_disappears (2364.13s)
--- PASS: TestAccOpenSearchVPCEndpoint_update (2523.79s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearch 2621.296s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/opensearch Issues and PRs that pertain to the opensearch service. partner Contribution from a partner. needs-triage Waiting for first response or review from a maintainer. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 10, 2023
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Jul 10, 2023
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 10, 2023
@ewbankkit
Copy link
Contributor

@lafod Thanks for the contribution 🎉 👏.
It looks like this resource should be renamed to aws_opensearch_vpc_endpoint to match the underlying AWS APIs.

@ewbankkit ewbankkit added the waiting-response Maintainers are waiting on response from community or contributor. label Aug 15, 2023
@ewbankkit ewbankkit removed their assignment Aug 15, 2023
@ewbankkit ewbankkit removed the waiting-response Maintainers are waiting on response from community or contributor. label Aug 15, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccOpenSearchVPCEndpoint_' PKG=opensearch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 20  -run=TestAccOpenSearchVPCEndpoint_ -timeout 720m
=== RUN   TestAccOpenSearchVPCEndpoint_basic
=== PAUSE TestAccOpenSearchVPCEndpoint_basic
=== RUN   TestAccOpenSearchVPCEndpoint_disappears
=== PAUSE TestAccOpenSearchVPCEndpoint_disappears
=== CONT  TestAccOpenSearchVPCEndpoint_basic
=== CONT  TestAccOpenSearchVPCEndpoint_disappears
--- PASS: TestAccOpenSearchVPCEndpoint_disappears (2400.59s)
--- PASS: TestAccOpenSearchVPCEndpoint_basic (2486.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	2491.548s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccOpenSearchDomainDataSource_Data_advanced\|TestAccOpenSearchVPCEndpoint_update' PKG=opensearch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 20  -run=TestAccOpenSearchDomainDataSource_Data_advanced\|TestAccOpenSearchVPCEndpoint_update -timeout 720m
=== RUN   TestAccOpenSearchDomainDataSource_Data_advanced
=== PAUSE TestAccOpenSearchDomainDataSource_Data_advanced
=== RUN   TestAccOpenSearchVPCEndpoint_update
=== PAUSE TestAccOpenSearchVPCEndpoint_update
=== CONT  TestAccOpenSearchDomainDataSource_Data_advanced
=== CONT  TestAccOpenSearchVPCEndpoint_update
--- PASS: TestAccOpenSearchDomainDataSource_Data_advanced (2349.01s)
--- PASS: TestAccOpenSearchVPCEndpoint_update (2645.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	2650.470s

@ewbankkit ewbankkit merged commit 4175420 into hashicorp:main Aug 16, 2023
41 checks passed
@github-actions github-actions bot added this to the v5.13.0 milestone Aug 16, 2023
@github-actions
Copy link

This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/opensearch Issues and PRs that pertain to the opensearch service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_opensearch_domain_vpc_endpoint
4 participants