-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct typos in Quicksight flatteners for visible_range
, rows
, and visibility
#32464
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
$ make testacc PKG=quicksight TESTS=TestAccQuickSightAnalysis_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightAnalysis_' -timeout 180m
? github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema [no test files]
--- PASS: TestAccQuickSightAnalysis_forceDelete (66.13s)
--- PASS: TestAccQuickSightAnalysis_parametersConfig (77.63s)
--- PASS: TestAccQuickSightAnalysis_disappears (82.51s)
--- PASS: TestAccQuickSightAnalysis_sourceEntity (82.62s)
--- PASS: TestAccQuickSightAnalysis_basic (88.76s)
--- PASS: TestAccQuickSightAnalysis_update (123.69s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 127.049s
$ make testacc PKG=quicksight TESTS=TestAccQuickSightDashboard_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightDashboard_' -timeout 180m
? github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema [no test files]
--- PASS: TestAccQuickSightDashboard_dashboardSpecificConfig (74.58s)
--- PASS: TestAccQuickSightDashboard_basic (75.44s)
--- PASS: TestAccQuickSightDashboard_disappears (82.13s)
--- PASS: TestAccQuickSightDashboard_sourceEntity (87.14s)
--- PASS: TestAccQuickSightDashboard_updateVersionNumber (130.51s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 133.963s
$ make testacc PKG=quicksight TESTS=TestAccQuickSightTemplate_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightTemplate_' -timeout 180m
? github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema [no test files]
--- PASS: TestAccQuickSightTemplate_disappears (56.96s)
--- PASS: TestAccQuickSightTemplate_barChart (61.01s)
--- PASS: TestAccQuickSightTemplate_basic (61.47s)
--- PASS: TestAccQuickSightTemplate_sourceEntity (63.19s)
--- PASS: TestAccQuickSightTemplate_table (87.59s)
--- PASS: TestAccQuickSightTemplate_update (96.64s)
--- PASS: TestAccQuickSightTemplate_tags (114.31s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 117.657s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This functionality has been released in v5.8.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
There were three typos in some of the Quicksight flattener functions that were leading to the following errors. This PR aims to correct them so that the data can successfully be written to the state.
I'm unsure on running the acceptance tests for this, so have left that out for now. I'd also be interested in how to properly approach the changelog entry for this, since it affects multiple resources due to the shared schema.
Relations
Closes #31923
Closes #32347
References
Schema reference for:
visible_range
rows
visibility
Output from Acceptance Testing
The acceptance tests for Quicksight are a bit unclear to me, so I'll need some assistance in running those, should it be needed for these typo fixes.