Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_route53_cidr_location: Fix Value Conversion Error on Read #32596

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jul 19, 2023

Description

Error raised here: https://github.com/hashicorp/terraform-plugin-framework/blob/fc2db9eeb8ffe2f621e9caf02ee4053adc8c41b6/internal/reflect/interfaces.go#L326-L338.

Relations

Closes #32441.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccRoute53CIDRLocation_' PKG=route53 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 2  -run=TestAccRoute53CIDRLocation_ -timeout 180m
=== RUN   TestAccRoute53CIDRLocation_basic
=== PAUSE TestAccRoute53CIDRLocation_basic
=== RUN   TestAccRoute53CIDRLocation_update
=== PAUSE TestAccRoute53CIDRLocation_update
=== CONT  TestAccRoute53CIDRLocation_basic
=== CONT  TestAccRoute53CIDRLocation_update
--- PASS: TestAccRoute53CIDRLocation_basic (25.61s)
--- PASS: TestAccRoute53CIDRLocation_update (40.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	46.335s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/route53 Issues and PRs that pertain to the route53 service. size/XS Managed by automation to categorize the size of a PR. labels Jul 19, 2023
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Jul 19, 2023
@ewbankkit ewbankkit merged commit 767ba7a into main Jul 19, 2023
46 checks passed
@ewbankkit ewbankkit deleted the b-aws_route53_cidr_location-ValueConversionError branch July 19, 2023 19:49
@github-actions github-actions bot added this to the v5.9.0 milestone Jul 19, 2023
github-actions bot pushed a commit that referenced this pull request Jul 19, 2023
@github-actions
Copy link

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/route53 Issues and PRs that pertain to the route53 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] aws_route53_cidr_location throws Value Conversion Error on cidr_blocks
1 participant