Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: add tests for ECS task definition - EFS volume - Transit encryption #32699

Closed
jeremychauvet opened this issue Jul 26, 2023 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope.

Comments

@jeremychauvet
Copy link
Contributor

jeremychauvet commented Jul 26, 2023

Purpose

Trying to qualifying issue #23541, I've seen that no test were covering this case (ECS task definition with encryption set to disabled and authorization_config also set to disable.

I'm opening this issue to solve this.

Test acceptance

New test added: TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
Output:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled'  -timeout 180m
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled (37.11s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        39.007s

Relates

@jeremychauvet jeremychauvet added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 26, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 26, 2023
@jeremychauvet jeremychauvet closed this as not planned Won't fix, can't repro, duplicate, stale Jul 26, 2023
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Jul 26, 2023
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

No branches or pull requests

1 participant