Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Change IRSA example to include only CA fingerprint #32847

Closed
pnieweglowski opened this issue Aug 3, 2023 · 4 comments · Fixed by #32903
Closed

[Docs]: Change IRSA example to include only CA fingerprint #32847

pnieweglowski opened this issue Aug 3, 2023 · 4 comments · Fixed by #32903
Labels
documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service.
Milestone

Comments

@pnieweglowski
Copy link

Documentation Link

website/docs/r/eks_cluster.html.markdown

Description

Pull request #26523 changed in example document, usage of resource aws_iam_openid_connect_provider, attribute thumbprint_list to contain list off all fingerprints from cert chain gathered from IdP.
As number of oidc's thumbprints in AWS is limited to 5, and cert chains with number of certificates exceeding 3 are quite common, it is easy to touch the hard limit of the resource.
In AWS IAM OIDC docs, there is a statement
IAM requires the thumbprint for the top intermediate certificate authority (CA) that signed the certificate used by the external identity provider (IdP)
so only first fingerprint from data.tls_certificate should be used.

References

https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_providers_create_oidc_verify-thumbprint.html

Would you like to implement a fix?

None

@pnieweglowski pnieweglowski added the documentation Introduces or discusses updates to documentation. label Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/iam Issues and PRs that pertain to the iam service. needs-triage Waiting for first response or review from a maintainer. labels Aug 3, 2023
@justinretzolk
Copy link
Member

Hey @pnieweglowski 👋 Thank you for taking the time to raise this, and for the helpful link! I've opened a pull request to update the documentation as needed.

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 8, 2023
@github-actions github-actions bot added this to the v5.12.0 milestone Aug 8, 2023
@github-actions
Copy link

This functionality has been released in v5.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants