Adding new resource aws_msk_cluster_policy

[nrajb]

Description

Adds support for MSK Resource Policy

Relations

Closes #31062.

References

go reference: https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/kafka
api reference: https://docs.aws.amazon.com/msk/1.0/apireference/clusters-clusterarn-policy.html

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAccKafkaClusterPolicy_basic' PKG=kafka  ACCTEST_PARALLELISM=2                                       

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafka/... -v -count 1 -parallel 2  -run=TestAccKafkaClusterPolicy_basic -timeout 180m
=== RUN   TestAccKafkaClusterPolicy_basic
=== PAUSE TestAccKafkaClusterPolicy_basic
=== CONT  TestAccKafkaClusterPolicy_basic
--- PASS: TestAccKafkaClusterPolicy_basic (41.25s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kafka      44.285s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[nrajb]

@ewbankkit Happy to resubmit the PR with clean branch now that #32775 is merged, please let me know.. 🙏

[ewbankkit]

@nrajb Don't worry -- I'll do the merge tomorrow and push the branch.

[vishwa-trulioo]

Looking forward to the aws_msk_cluster_policy resource soon. You rock!

[ewbankkit]

% make testacc TESTARGS='-run=TestAccKafkaClusterPolicy_' PKG=kafka
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafka/... -v -count 1 -parallel 20  -run=TestAccKafkaClusterPolicy_ -timeout 180m
=== RUN   TestAccKafkaClusterPolicy_basic
=== PAUSE TestAccKafkaClusterPolicy_basic
=== RUN   TestAccKafkaClusterPolicy_disappears
=== PAUSE TestAccKafkaClusterPolicy_disappears
=== CONT  TestAccKafkaClusterPolicy_basic
=== CONT  TestAccKafkaClusterPolicy_disappears
=== NAME  TestAccKafkaClusterPolicy_basic
    cluster_policy_test.go:29: Step 1/2 error: Error running apply: exit status 1
        
        Error: setting MSK Cluster Policy (arn:aws:kafka:us-west-2:123456789012:cluster/tf-acc-test-5857099149822587167/ceefe3b8-6bfe-4ee2-8b15-d6dabb49c660-12): operation error Kafka: PutClusterPolicy, https response error StatusCode: 400, RequestID: da71570f-4bd1-436b-ac53-19def7536c45, BadRequestException: The cluster must have multi-VPC private connectivity enabled for its cluster policy.
        
          with aws_msk_cluster_policy.test,
          on terraform_plugin_test.tf line 62, in resource "aws_msk_cluster_policy" "test":
          62: resource "aws_msk_cluster_policy" "test" {
        
=== NAME  TestAccKafkaClusterPolicy_disappears
    cluster_policy_test.go:62: Step 1/1 error: Error running apply: exit status 1
        
        Error: setting MSK Cluster Policy (arn:aws:kafka:us-west-2:123456789012:cluster/tf-acc-test-2225640158714645767/eeaf73af-5bc9-4772-a3ba-654701643429-12): operation error Kafka: PutClusterPolicy, https response error StatusCode: 400, RequestID: 3397791b-439b-46a4-8fcf-d4735abd15f4, BadRequestException: The cluster must have multi-VPC private connectivity enabled for its cluster policy.
        
          with aws_msk_cluster_policy.test,
          on terraform_plugin_test.tf line 62, in resource "aws_msk_cluster_policy" "test":
          62: resource "aws_msk_cluster_policy" "test" {
        
--- FAIL: TestAccKafkaClusterPolicy_basic (2417.74s)
--- FAIL: TestAccKafkaClusterPolicy_disappears (2428.68s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/kafka	2434.239s
FAIL
make: *** [testacc] Error 1

[ewbankkit]

LGTM 🚀.

% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccKafkaClusterPolicy_' PKG=kafka ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafka/... -v -count 1 -parallel 1  -run=TestAccKafkaClusterPolicy_ -timeout 360m
=== RUN   TestAccKafkaClusterPolicy_basic
=== PAUSE TestAccKafkaClusterPolicy_basic
=== RUN   TestAccKafkaClusterPolicy_disappears
=== PAUSE TestAccKafkaClusterPolicy_disappears
=== CONT  TestAccKafkaClusterPolicy_basic
--- PASS: TestAccKafkaClusterPolicy_basic (6802.15s)
=== CONT  TestAccKafkaClusterPolicy_disappears
--- PASS: TestAccKafkaClusterPolicy_disappears (6762.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafka	13844.376s

[ewbankkit]

@nrajb Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.