Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add ReadOnlyAdmins Argument to aws_lakeformation_data_lake_settings Resource and Data Source #33143

Closed
brascher opened this issue Aug 22, 2023 · 3 comments · Fixed by #33189
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/lakeformation Issues and PRs that pertain to the lakeformation service.
Milestone

Comments

@brascher
Copy link

Description

The "ReadOnlyAdmins" property recently released for AWS Data Lake Settings PutDataLakeSettings and GetDataLakeSettings is not available in the aws_lakeformation_data_lake_settings Terraform resource or data source.

Affected Resource(s) and/or Data Source(s)

  • aws_lakeformation_data_lake_settings Resource
  • aws_lakeformation_data_lake_settings Data Source

Potential Terraform Configuration

resource "aws_lakeformation_data_lake_settings" "example" {
  admins           = [aws_iam_user.test.arn, aws_iam_role.test.arn]
  read_only_admins = [aws_iam_user.read_only_test.arn, aws_iam_role.read_only_test.arn]
}

References

Would you like to implement a fix?

None

@brascher brascher added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 22, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/lakeformation Issues and PRs that pertain to the lakeformation service. label Aug 22, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 22, 2023
@justinretzolk justinretzolk added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 22, 2023
@github-actions github-actions bot added this to the v5.15.0 milestone Aug 25, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This functionality has been released in v5.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/lakeformation Issues and PRs that pertain to the lakeformation service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants