Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_datasync_location_fsx_openzfs_file_system: Fix setting protocol: Invalid address to set errors #33225

Merged

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Aug 29, 2023

Description

Fixes flattener.

Relations

Closes #33221.

Output from Acceptance Testing

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccDataSyncLocationFSxOpenZFSFileSystem_\|TestAccDataSyncLocationFSxLustreFileSystem_basic\|TestAccDataSyncLocationFSxONTAPFileSystem_basic\|TestAccDataSyncLocationFSxWindowsFileSystem_basic' PKG=datasync ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 2  -run=TestAccDataSyncLocationFSxOpenZFSFileSystem_\|TestAccDataSyncLocationFSxLustreFileSystem_basic\|TestAccDataSyncLocationFSxONTAPFileSystem_basic\|TestAccDataSyncLocationFSxWindowsFileSystem_basic -timeout 720m
=== RUN   TestAccDataSyncLocationFSxLustreFileSystem_basic
=== PAUSE TestAccDataSyncLocationFSxLustreFileSystem_basic
=== RUN   TestAccDataSyncLocationFSxONTAPFileSystem_basic
=== PAUSE TestAccDataSyncLocationFSxONTAPFileSystem_basic
=== RUN   TestAccDataSyncLocationFSxOpenZFSFileSystem_basic
=== PAUSE TestAccDataSyncLocationFSxOpenZFSFileSystem_basic
=== RUN   TestAccDataSyncLocationFSxOpenZFSFileSystem_disappears
=== PAUSE TestAccDataSyncLocationFSxOpenZFSFileSystem_disappears
=== RUN   TestAccDataSyncLocationFSxOpenZFSFileSystem_subdirectory
=== PAUSE TestAccDataSyncLocationFSxOpenZFSFileSystem_subdirectory
=== RUN   TestAccDataSyncLocationFSxOpenZFSFileSystem_tags
=== PAUSE TestAccDataSyncLocationFSxOpenZFSFileSystem_tags
=== RUN   TestAccDataSyncLocationFSxWindowsFileSystem_basic
=== PAUSE TestAccDataSyncLocationFSxWindowsFileSystem_basic
=== CONT  TestAccDataSyncLocationFSxLustreFileSystem_basic
=== CONT  TestAccDataSyncLocationFSxOpenZFSFileSystem_subdirectory
--- PASS: TestAccDataSyncLocationFSxLustreFileSystem_basic (676.42s)
=== CONT  TestAccDataSyncLocationFSxOpenZFSFileSystem_basic
--- PASS: TestAccDataSyncLocationFSxOpenZFSFileSystem_subdirectory (757.44s)
=== CONT  TestAccDataSyncLocationFSxOpenZFSFileSystem_disappears
--- PASS: TestAccDataSyncLocationFSxOpenZFSFileSystem_basic (716.03s)
=== CONT  TestAccDataSyncLocationFSxONTAPFileSystem_basic
--- PASS: TestAccDataSyncLocationFSxOpenZFSFileSystem_disappears (780.52s)
=== CONT  TestAccDataSyncLocationFSxWindowsFileSystem_basic
--- PASS: TestAccDataSyncLocationFSxONTAPFileSystem_basic (2123.68s)
=== CONT  TestAccDataSyncLocationFSxOpenZFSFileSystem_tags
--- PASS: TestAccDataSyncLocationFSxOpenZFSFileSystem_tags (843.44s)
--- PASS: TestAccDataSyncLocationFSxWindowsFileSystem_basic (3280.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	4825.256s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/S Managed by automation to categorize the size of a PR. label Aug 29, 2023
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/datasync Issues and PRs that pertain to the datasync service. labels Aug 29, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 29, 2023
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Aug 29, 2023
@ewbankkit ewbankkit merged commit 60c060a into main Aug 30, 2023
53 checks passed
@ewbankkit ewbankkit deleted the b-aws_datasync_location_fsx_openzfs_file_system.InvalidAddress branch August 30, 2023 13:04
@github-actions github-actions bot added this to the v5.15.0 milestone Aug 30, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This functionality has been released in v5.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/datasync Issues and PRs that pertain to the datasync service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants