Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pinpoint email templates #33266

Merged
merged 17 commits into from
Aug 10, 2024
Merged

Conversation

bashtoni
Copy link
Contributor

Description

Adds support for Amazon Pinpoint Email templates.

Relations

Closes #14293

References

Output from Acceptance Testing

% make testacc TESTS=TestAccPinpointEmailTemplate_ PKG=pinpoint
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/pinpoint/... -v -count 1 -parallel 20 -run='TestAccPinpointEmailTemplate_'  -timeout 180m
=== RUN   TestAccPinpointEmailTemplate_basic
=== PAUSE TestAccPinpointEmailTemplate_basic
=== RUN   TestAccPinpointEmailTemplate_update
=== PAUSE TestAccPinpointEmailTemplate_update
=== CONT  TestAccPinpointEmailTemplate_basic
=== CONT  TestAccPinpointEmailTemplate_update
--- PASS: TestAccPinpointEmailTemplate_basic (32.35s)
--- PASS: TestAccPinpointEmailTemplate_update (71.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pinpoint	71.987s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/pinpoint Issues and PRs that pertain to the pinpoint service. generators Relates to code generators. and removed size/XL Managed by automation to categorize the size of a PR. labels Aug 31, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 31, 2023
@rocky4570
Copy link

👍

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 6, 2023
@chefren
Copy link

chefren commented Dec 19, 2023

@jar-b are you able to assign reviewer/review please?

@cemo
Copy link

cemo commented Dec 25, 2023

@jar-b can you assign reviewer please? I would like to send PR remaining related Pinpoint resources.

@vl-kp
Copy link

vl-kp commented Jan 5, 2024

Anyone can merge it?

@cemo
Copy link

cemo commented Jan 28, 2024

Hey @justinretzolk would you please merge this?

@justinretzolk
Copy link
Member

Hey @cemo 👋 Thanks for checking in here! I can't speak to when this will be prioritized just yet. We base our prioritization on the count of 👍 reactions and a few other considerations (more information: prioritization guide).

@nam054 nam054 self-assigned this Aug 9, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 9, 2024
@nam054 nam054 requested a review from a team as a code owner August 9, 2024 07:39
Copy link

github-actions bot commented Aug 9, 2024

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

Copy link
Contributor

@nam054 nam054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Thank you for your contribution!

> make testacc TESTARGS='-run=TestAccPinpointEmailTemplate_' PKG=pinpoint
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/pinpoint/... -v -count 1 -parallel 20  -run=TestAccPinpointEmailTemplate_ -timeout 360m
=== RUN   TestAccPinpointEmailTemplate_basic
=== PAUSE TestAccPinpointEmailTemplate_basic
=== RUN   TestAccPinpointEmailTemplate_update
=== PAUSE TestAccPinpointEmailTemplate_update
=== RUN   TestAccPinpointEmailTemplate_tags
=== PAUSE TestAccPinpointEmailTemplate_tags
=== CONT  TestAccPinpointEmailTemplate_basic
=== CONT  TestAccPinpointEmailTemplate_tags
=== CONT  TestAccPinpointEmailTemplate_update
--- PASS: TestAccPinpointEmailTemplate_tags (16.01s)
--- PASS: TestAccPinpointEmailTemplate_basic (16.09s)
--- PASS: TestAccPinpointEmailTemplate_update (24.17s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/pinpoint   28.890s

@nam054 nam054 merged commit 5d0eddb into hashicorp:main Aug 10, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.63.0 milestone Aug 10, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 15, 2024
Copy link

This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/pinpoint Issues and PRs that pertain to the pinpoint service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform equivalent of aws pinpoint create-email-template
7 participants