-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pinpoint email templates #33266
Add Pinpoint email templates #33266
Conversation
Community NoteVoting for Prioritization
For Submitters
|
0aa5f4e
to
4d6e93a
Compare
👍 |
@jar-b are you able to assign reviewer/review please? |
@jar-b can you assign reviewer please? I would like to send PR remaining related Pinpoint resources. |
Anyone can merge it? |
Hey @justinretzolk would you please merge this? |
Hey @cemo 👋 Thanks for checking in here! I can't speak to when this will be prioritized just yet. We base our prioritization on the count of 👍 reactions and a few other considerations (more information: prioritization guide). |
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
9797e9a
to
a505821
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 Thank you for your contribution!
> make testacc TESTARGS='-run=TestAccPinpointEmailTemplate_' PKG=pinpoint
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/pinpoint/... -v -count 1 -parallel 20 -run=TestAccPinpointEmailTemplate_ -timeout 360m
=== RUN TestAccPinpointEmailTemplate_basic
=== PAUSE TestAccPinpointEmailTemplate_basic
=== RUN TestAccPinpointEmailTemplate_update
=== PAUSE TestAccPinpointEmailTemplate_update
=== RUN TestAccPinpointEmailTemplate_tags
=== PAUSE TestAccPinpointEmailTemplate_tags
=== CONT TestAccPinpointEmailTemplate_basic
=== CONT TestAccPinpointEmailTemplate_tags
=== CONT TestAccPinpointEmailTemplate_update
--- PASS: TestAccPinpointEmailTemplate_tags (16.01s)
--- PASS: TestAccPinpointEmailTemplate_basic (16.09s)
--- PASS: TestAccPinpointEmailTemplate_update (24.17s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/pinpoint 28.890s
This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds support for Amazon Pinpoint Email templates.
Relations
Closes #14293
References
Output from Acceptance Testing