RDS custom engine version (CEV) #33285

AdamTylerLynch · 2023-09-01T23:51:25Z

Description

RDS Custom engine version (CEV) support for RDS Custom for SQL Server and RDS Custom for Oracle.

*** Requires prerequisite AMIs/installation media! ****
Requires the following Environment Variables
RDS_CUSTOM_WINDOWS_SQLSERVER_AMI (AMI name like "ami-123bbb333444nn")
RDS_CUSTOM_ORACLE_S3_BUCKET (bucket name like "mybucket")

Relations

Closes #0000

References

Output from Acceptance Testing

make testacc PKG=rds TESTS=TestAccRDSCustomDBEngineVersion_ ACCTEST_PARALLELISM=5 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 5 -run='TestAccRDSCustomDBEngineVersion_'  -timeout 180m
=== RUN   TestAccRDSCustomDBEngineVersion_sqlServer
=== PAUSE TestAccRDSCustomDBEngineVersion_sqlServer
=== RUN   TestAccRDSCustomDBEngineVersion_sqlServerUpdate
=== PAUSE TestAccRDSCustomDBEngineVersion_sqlServerUpdate
=== RUN   TestAccRDSCustomDBEngineVersion_oracle
=== PAUSE TestAccRDSCustomDBEngineVersion_oracle
=== RUN   TestAccRDSCustomDBEngineVersion_manifestFile
=== PAUSE TestAccRDSCustomDBEngineVersion_manifestFile
=== RUN   TestAccRDSCustomDBEngineVersion_disappears
=== PAUSE TestAccRDSCustomDBEngineVersion_disappears
=== CONT  TestAccRDSCustomDBEngineVersion_sqlServer
=== CONT  TestAccRDSCustomDBEngineVersion_manifestFile
=== CONT  TestAccRDSCustomDBEngineVersion_disappears
=== CONT  TestAccRDSCustomDBEngineVersion_oracle
=== CONT  TestAccRDSCustomDBEngineVersion_sqlServerUpdate
--- PASS: TestAccRDSCustomDBEngineVersion_sqlServer (292.13s)
--- PASS: TestAccRDSCustomDBEngineVersion_sqlServerUpdate (298.21s)
--- PASS: TestAccRDSCustomDBEngineVersion_disappears (322.95s)
--- PASS: TestAccRDSCustomDBEngineVersion_oracle (5916.96s)
--- PASS: TestAccRDSCustomDBEngineVersion_manifestFile (6219.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	6225.743s

github-actions · 2023-09-01T23:51:41Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

AdamTylerLynch · 2023-09-01T23:51:48Z

Need to add Tags on create test. Does not support Tags update.

AdamTylerLynch · 2023-09-05T18:08:45Z

 make testacc PKG=rds TESTS=TestAccRDSCustomDBEngineVersion_tags ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 5 -run='TestAccRDSCustomDBEngineVersion_tags'  -timeout 180m
=== RUN   TestAccRDSCustomDBEngineVersion_tags
=== PAUSE TestAccRDSCustomDBEngineVersion_tags
=== CONT  TestAccRDSCustomDBEngineVersion_tags
--- PASS: TestAccRDSCustomDBEngineVersion_tags (180.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	186.731s

ddericco

Added a few comments/suggestions for review, and fixes to documentation.

internal/service/rds/custom_db_engine_version.go

website/docs/r/rds_custom_db_engine_version.markdown

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSCustomDBEngineVersion_' PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSCustomDBEngineVersion_ -timeout 180m
=== RUN   TestAccRDSCustomDBEngineVersion_sqlServer
    custom_db_engine_version_test.go:37: Environment variable RDS_CUSTOM_WINDOWS_SQLSERVER_AMI is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_sqlServer (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_sqlServerUpdate
    custom_db_engine_version_test.go:83: Environment variable RDS_CUSTOM_WINDOWS_SQLSERVER_AMI is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_sqlServerUpdate (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_oracle
    custom_db_engine_version_test.go:139: Environment variable RDS_CUSTOM_ORACLE_S3_BUCKET is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_oracle (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_manifestFile
    custom_db_engine_version_test.go:185: Environment variable RDS_CUSTOM_ORACLE_S3_BUCKET is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_manifestFile (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_tags
    custom_db_engine_version_test.go:231: Environment variable RDS_CUSTOM_WINDOWS_SQLSERVER_AMI is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_tags (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_disappears
    custom_db_engine_version_test.go:269: Environment variable RDS_CUSTOM_WINDOWS_SQLSERVER_AMI is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_disappears (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	7.644s

@ddericco

Waiting for response to @ddericco's review

Co-authored-by: Dave DeRicco <30156588+ddericco@users.noreply.github.com>

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSCustomDBEngineVersion_' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCustomDBEngineVersion_ -timeout 360m
=== RUN   TestAccRDSCustomDBEngineVersion_sqlServer
    custom_db_engine_version_test.go:37: Environment variable RDS_CUSTOM_WINDOWS_SQLSERVER_AMI is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_sqlServer (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_sqlServerUpdate
    custom_db_engine_version_test.go:83: Environment variable RDS_CUSTOM_WINDOWS_SQLSERVER_AMI is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_sqlServerUpdate (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_oracle
    custom_db_engine_version_test.go:139: Environment variable RDS_CUSTOM_ORACLE_S3_BUCKET is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_oracle (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_manifestFile
    custom_db_engine_version_test.go:185: Environment variable RDS_CUSTOM_ORACLE_S3_BUCKET is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_manifestFile (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_tags
    custom_db_engine_version_test.go:231: Environment variable RDS_CUSTOM_WINDOWS_SQLSERVER_AMI is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_tags (0.00s)
=== RUN   TestAccRDSCustomDBEngineVersion_disappears
    custom_db_engine_version_test.go:269: Environment variable RDS_CUSTOM_WINDOWS_SQLSERVER_AMI is not set
--- SKIP: TestAccRDSCustomDBEngineVersion_disappears (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	5.437s

ewbankkit · 2023-09-26T17:40:36Z

@AdamTylerLynch Thanks for the contribution 🎉 👏.

github-actions · 2023-09-29T01:04:17Z

This functionality has been released in v5.19.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-10-29T02:04:17Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

AdamTylerLynch added 11 commits August 25, 2023 10:03

adding CEV support

da6bd9e

Added Create and Read

78aa3fb

updated waiters

3e349df

added CEVs

8ee6c5f

Merge branch 'main' into f-rds_custom_engine_version

4a75f0b

added to package gen

961689d

added CfSS, CfO

1e26ba5

added tests and updates

92f4e74

making tetests callable

d030bf1

added source AMI support, buttoned up tests.

c1c7756

Merge branch 'main' into f-rds_custom_engine_version

84e8320

terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Sep 1, 2023

AdamTylerLynch added 7 commits September 5, 2023 09:11

added changelog

902790d

renamed docs file

d275531

fix lint: Regex Cache

dc86de6

lint-fix null output checking

2bfca0b

removed generated html.markdown

3cacd81

lint-fix: website spacing

571ae6e

added tags testing

e8ff542

AdamTylerLynch requested a review from ewbankkit September 5, 2023 18:33

AdamTylerLynch changed the title ~~[WIP] RDS custom engine version (CEV)~~ RDS custom engine version (CEV) Sep 5, 2023

ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 6, 2023

ewbankkit added 2 commits September 6, 2023 10:59

Tweak CHANGELOG entry.

bb5ca41

Tweak documentation.

2ee2a4f

ddericco reviewed Sep 6, 2023

View reviewed changes

ewbankkit previously approved these changes Sep 6, 2023

View reviewed changes

ewbankkit self-requested a review September 6, 2023 15:12

ewbankkit and others added 2 commits September 12, 2023 11:45

Update website/docs/r/rds_custom_db_engine_version.markdown

4eca3c7

Co-authored-by: Dave DeRicco <30156588+ddericco@users.noreply.github.com>

Update website/docs/r/rds_custom_db_engine_version.markdown

748acb6

Co-authored-by: Dave DeRicco <30156588+ddericco@users.noreply.github.com>

ewbankkit self-assigned this Sep 26, 2023

terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 26, 2023

Merge branch 'main' into HEAD

4733463

ewbankkit approved these changes Sep 26, 2023

View reviewed changes

ewbankkit merged commit a425ad0 into hashicorp:main Sep 26, 2023
41 checks passed

github-actions bot added this to the v5.19.0 milestone Sep 26, 2023

AdamTylerLynch mentioned this pull request Sep 27, 2023

Doc Formatting - RDS Custom Engine Version #33647

Merged

github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RDS custom engine version (CEV) #33285

RDS custom engine version (CEV) #33285

AdamTylerLynch commented Sep 1, 2023 •

edited

Loading

github-actions bot commented Sep 1, 2023

AdamTylerLynch commented Sep 1, 2023

AdamTylerLynch commented Sep 5, 2023

ddericco left a comment

ewbankkit left a comment

ewbankkit left a comment

ewbankkit commented Sep 26, 2023

github-actions bot commented Sep 29, 2023

github-actions bot commented Oct 29, 2023

RDS custom engine version (CEV) #33285

RDS custom engine version (CEV) #33285

Conversation

AdamTylerLynch commented Sep 1, 2023 • edited Loading

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Sep 1, 2023

Community Note

AdamTylerLynch commented Sep 1, 2023

AdamTylerLynch commented Sep 5, 2023

ddericco left a comment

Choose a reason for hiding this comment

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Sep 26, 2023

github-actions bot commented Sep 29, 2023

github-actions bot commented Oct 29, 2023

AdamTylerLynch commented Sep 1, 2023 •

edited

Loading