-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow default_tags to be set by environment variables #33339
Conversation
Community NoteVoting for Prioritization
For Submitters
|
14e2a3e
to
033814f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @jtdoepke 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
033814f
to
49af782
Compare
49af782
to
855c79a
Compare
Just wondering what's left to get this over the line? We could really use this functionality. |
This commit has the provider consume default_tags from environment variables with the form `TF_AWS_DEFAULT_TAGS_<tag_name>=<tag_value>`. If the same tag is defined in both an environment variable and the Terraform config, the Terraform takes precedence.
855c79a
to
d92e0e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thanks for your contribution, @jtdoepke! 👍 |
This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This commit has the provider consume
default_tags
from environment variables with the formTF_AWS_DEFAULT_TAGS_<tag_name>=<tag_value>
. If the same tag is defined in both an environment variable and the Terraform config, the Terraform takes precedence.Relations
Closes #33255
References
Output from Acceptance Testing