Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws_schemas_schema): add JSON Schema support #33442

Merged

Conversation

brennovich
Copy link
Contributor

Description

This commit relies on types exposed by aws-sdk-go-v2 to compose the validation of the aws_schemas_schema types as it includes JSONSchemaDraft4.

This is a long supported featured by AWS and a years long request from Terraform users.

Relations

Closes #23753

References

Output from Acceptance Testing

Add TestAccSchemasSchema_jsonSchemaDraftv4

%$ make testacc TESTS=TestAccSchemasSchema_jsonSchemaDraftv4 PKG=schemas

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/schemas/... -v -count 1 -parallel 20 -run='TestAccSchemasSchema_jsonSchemaDraftv4'  -timeout 180m
=== RUN   TestAccSchemasSchema_jsonSchemaDraftv4
=== PAUSE TestAccSchemasSchema_jsonSchemaDraftv4
=== CONT  TestAccSchemasSchema_jsonSchemaDraftv4
--- PASS: TestAccSchemasSchema_jsonSchemaDraftv4 (27.72s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/schemas    28.118s

This commit relies on types exposed by `aws-sdk-go-v2` to compose the
validation of the `aws_schemas_schema` types as it includes
`JSONSchemaDraft4`.

This is a long supported featured by AWS and a years long request
from Terraform users.

Ref. hashicorp#23753
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/schemas Issues and PRs that pertain to the schemas service. labels Sep 13, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 13, 2023
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @brennovich 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 13, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSchemasSchema_' PKG=schemas ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/schemas/... -v -count 1 -parallel 2  -run=TestAccSchemasSchema_ -timeout 180m
=== RUN   TestAccSchemasSchema_openAPI3
=== PAUSE TestAccSchemasSchema_openAPI3
=== RUN   TestAccSchemasSchema_jsonSchemaDraftv4
=== PAUSE TestAccSchemasSchema_jsonSchemaDraftv4
=== RUN   TestAccSchemasSchema_disappears
=== PAUSE TestAccSchemasSchema_disappears
=== RUN   TestAccSchemasSchema_contentDescription
=== PAUSE TestAccSchemasSchema_contentDescription
=== RUN   TestAccSchemasSchema_tags
=== PAUSE TestAccSchemasSchema_tags
=== CONT  TestAccSchemasSchema_openAPI3
=== CONT  TestAccSchemasSchema_contentDescription
--- PASS: TestAccSchemasSchema_openAPI3 (26.07s)
=== CONT  TestAccSchemasSchema_tags
--- PASS: TestAccSchemasSchema_contentDescription (60.49s)
=== CONT  TestAccSchemasSchema_disappears
--- PASS: TestAccSchemasSchema_disappears (20.76s)
=== CONT  TestAccSchemasSchema_jsonSchemaDraftv4
--- PASS: TestAccSchemasSchema_tags (58.50s)
--- PASS: TestAccSchemasSchema_jsonSchemaDraftv4 (23.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/schemas	109.599s

@ewbankkit
Copy link
Contributor

@brennovich Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit bd7df93 into hashicorp:main Sep 14, 2023
41 checks passed
@github-actions github-actions bot added this to the v5.17.0 milestone Sep 14, 2023
@github-actions
Copy link

This functionality has been released in v5.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@brennovich brennovich deleted the f-aws_schemas_schema-add-jsonschema branch September 15, 2023 08:27
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/schemas Issues and PRs that pertain to the schemas service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add support for JSONSchemaDraft4 in resource aws_schemas_schema
3 participants