-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_fsx_ontap_storage_virtual_machine: In-place update of all active_directory_configuration
attributes
#33466
Conversation
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccFSxONTAPFileSystem_' PKG=fsx ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 3 -run=TestAccFSxONTAPFileSystem_ -timeout 720m === RUN TestAccFSxONTAPFileSystem_basic === PAUSE TestAccFSxONTAPFileSystem_basic === RUN TestAccFSxONTAPFileSystem_singleAZ === PAUSE TestAccFSxONTAPFileSystem_singleAZ === RUN TestAccFSxONTAPFileSystem_fsxAdminPassword === PAUSE TestAccFSxONTAPFileSystem_fsxAdminPassword === RUN TestAccFSxONTAPFileSystem_endpointIPAddressRange === PAUSE TestAccFSxONTAPFileSystem_endpointIPAddressRange === RUN TestAccFSxONTAPFileSystem_diskIOPS === PAUSE TestAccFSxONTAPFileSystem_diskIOPS === RUN TestAccFSxONTAPFileSystem_disappears === PAUSE TestAccFSxONTAPFileSystem_disappears === RUN TestAccFSxONTAPFileSystem_securityGroupIDs === PAUSE TestAccFSxONTAPFileSystem_securityGroupIDs === RUN TestAccFSxONTAPFileSystem_routeTableIDs === PAUSE TestAccFSxONTAPFileSystem_routeTableIDs === RUN TestAccFSxONTAPFileSystem_tags === PAUSE TestAccFSxONTAPFileSystem_tags === RUN TestAccFSxONTAPFileSystem_weeklyMaintenanceStartTime === PAUSE TestAccFSxONTAPFileSystem_weeklyMaintenanceStartTime === RUN TestAccFSxONTAPFileSystem_automaticBackupRetentionDays === PAUSE TestAccFSxONTAPFileSystem_automaticBackupRetentionDays === RUN TestAccFSxONTAPFileSystem_kmsKeyID === PAUSE TestAccFSxONTAPFileSystem_kmsKeyID === RUN TestAccFSxONTAPFileSystem_dailyAutomaticBackupStartTime === PAUSE TestAccFSxONTAPFileSystem_dailyAutomaticBackupStartTime === RUN TestAccFSxONTAPFileSystem_throughputCapacity === PAUSE TestAccFSxONTAPFileSystem_throughputCapacity === RUN TestAccFSxONTAPFileSystem_storageCapacity === PAUSE TestAccFSxONTAPFileSystem_storageCapacity === CONT TestAccFSxONTAPFileSystem_basic === CONT TestAccFSxONTAPFileSystem_tags === CONT TestAccFSxONTAPFileSystem_dailyAutomaticBackupStartTime --- PASS: TestAccFSxONTAPFileSystem_dailyAutomaticBackupStartTime (1974.50s) === CONT TestAccFSxONTAPFileSystem_storageCapacity --- PASS: TestAccFSxONTAPFileSystem_basic (1998.49s) === CONT TestAccFSxONTAPFileSystem_diskIOPS --- PASS: TestAccFSxONTAPFileSystem_tags (2025.37s) === CONT TestAccFSxONTAPFileSystem_routeTableIDs --- PASS: TestAccFSxONTAPFileSystem_diskIOPS (2056.42s) === CONT TestAccFSxONTAPFileSystem_securityGroupIDs --- PASS: TestAccFSxONTAPFileSystem_storageCapacity (2088.41s) === CONT TestAccFSxONTAPFileSystem_disappears --- PASS: TestAccFSxONTAPFileSystem_routeTableIDs (2053.82s) === CONT TestAccFSxONTAPFileSystem_fsxAdminPassword --- PASS: TestAccFSxONTAPFileSystem_disappears (1777.51s) === CONT TestAccFSxONTAPFileSystem_automaticBackupRetentionDays --- PASS: TestAccFSxONTAPFileSystem_fsxAdminPassword (2077.57s) === CONT TestAccFSxONTAPFileSystem_kmsKeyID --- PASS: TestAccFSxONTAPFileSystem_securityGroupIDs (3811.34s) === CONT TestAccFSxONTAPFileSystem_endpointIPAddressRange --- PASS: TestAccFSxONTAPFileSystem_automaticBackupRetentionDays (2062.42s) === CONT TestAccFSxONTAPFileSystem_singleAZ --- PASS: TestAccFSxONTAPFileSystem_singleAZ (1886.95s) === CONT TestAccFSxONTAPFileSystem_throughputCapacity --- PASS: TestAccFSxONTAPFileSystem_kmsKeyID (1954.79s) === CONT TestAccFSxONTAPFileSystem_weeklyMaintenanceStartTime --- PASS: TestAccFSxONTAPFileSystem_endpointIPAddressRange (1781.05s) --- PASS: TestAccFSxONTAPFileSystem_weeklyMaintenanceStartTime (1934.10s) --- PASS: TestAccFSxONTAPFileSystem_throughputCapacity (3447.49s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/fsx 11358.426s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccFSxONTAPFileSystem_singleAZ\|TestAccFSxWindowsFileSystem_audit\|TestAccFSxWindowsFileSystem_storageCapacity\|TestAccFSxWindowsFileSystem_throughputCapacity\|TestAccFSxLustreFileSystem_dailyAutomaticBackupStartTime\|TestAccFSxLustreFileSystem_kmsKeyID' PKG=fsx ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 2 -run=TestAccFSxONTAPFileSystem_singleAZ\|TestAccFSxWindowsFileSystem_audit\|TestAccFSxWindowsFileSystem_storageCapacity\|TestAccFSxWindowsFileSystem_throughputCapacity\|TestAccFSxLustreFileSystem_dailyAutomaticBackupStartTime\|TestAccFSxLustreFileSystem_kmsKeyID -timeout 720m === RUN TestAccFSxLustreFileSystem_dailyAutomaticBackupStartTime === PAUSE TestAccFSxLustreFileSystem_dailyAutomaticBackupStartTime === RUN TestAccFSxLustreFileSystem_kmsKeyID === PAUSE TestAccFSxLustreFileSystem_kmsKeyID === RUN TestAccFSxONTAPFileSystem_singleAZ === PAUSE TestAccFSxONTAPFileSystem_singleAZ === RUN TestAccFSxWindowsFileSystem_storageCapacity === PAUSE TestAccFSxWindowsFileSystem_storageCapacity === RUN TestAccFSxWindowsFileSystem_throughputCapacity === PAUSE TestAccFSxWindowsFileSystem_throughputCapacity === RUN TestAccFSxWindowsFileSystem_audit === PAUSE TestAccFSxWindowsFileSystem_audit === CONT TestAccFSxLustreFileSystem_dailyAutomaticBackupStartTime === CONT TestAccFSxWindowsFileSystem_storageCapacity --- PASS: TestAccFSxLustreFileSystem_dailyAutomaticBackupStartTime (671.72s) === CONT TestAccFSxWindowsFileSystem_audit --- PASS: TestAccFSxWindowsFileSystem_storageCapacity (4720.84s) === CONT TestAccFSxWindowsFileSystem_throughputCapacity --- PASS: TestAccFSxWindowsFileSystem_audit (4135.60s) === CONT TestAccFSxONTAPFileSystem_singleAZ --- PASS: TestAccFSxONTAPFileSystem_singleAZ (1886.95s) === CONT TestAccFSxLustreFileSystem_kmsKeyID --- PASS: TestAccFSxLustreFileSystem_kmsKeyID (1219.47s) --- PASS: TestAccFSxWindowsFileSystem_throughputCapacity (4836.60s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/fsx 8864.639s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccFSxONTAPStorageVirtualMachine_' PKG=fsx ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 2 -run=TestAccFSxONTAPStorageVirtualMachine_ -timeout 720m === RUN TestAccFSxONTAPStorageVirtualMachine_basic === PAUSE TestAccFSxONTAPStorageVirtualMachine_basic === RUN TestAccFSxONTAPStorageVirtualMachine_rootVolumeSecurityStyle === PAUSE TestAccFSxONTAPStorageVirtualMachine_rootVolumeSecurityStyle === RUN TestAccFSxONTAPStorageVirtualMachine_svmAdminPassword === PAUSE TestAccFSxONTAPStorageVirtualMachine_svmAdminPassword === RUN TestAccFSxONTAPStorageVirtualMachine_disappears === PAUSE TestAccFSxONTAPStorageVirtualMachine_disappears === RUN TestAccFSxONTAPStorageVirtualMachine_name === PAUSE TestAccFSxONTAPStorageVirtualMachine_name === RUN TestAccFSxONTAPStorageVirtualMachine_tags === PAUSE TestAccFSxONTAPStorageVirtualMachine_tags === RUN TestAccFSxONTAPStorageVirtualMachine_activeDirectory === PAUSE TestAccFSxONTAPStorageVirtualMachine_activeDirectory === CONT TestAccFSxONTAPStorageVirtualMachine_basic === CONT TestAccFSxONTAPStorageVirtualMachine_name --- PASS: TestAccFSxONTAPStorageVirtualMachine_basic (2239.26s) === CONT TestAccFSxONTAPStorageVirtualMachine_activeDirectory --- PASS: TestAccFSxONTAPStorageVirtualMachine_name (2433.31s) === CONT TestAccFSxONTAPStorageVirtualMachine_svmAdminPassword --- PASS: TestAccFSxONTAPStorageVirtualMachine_activeDirectory (2499.21s) === CONT TestAccFSxONTAPStorageVirtualMachine_disappears --- PASS: TestAccFSxONTAPStorageVirtualMachine_svmAdminPassword (2308.27s) === CONT TestAccFSxONTAPStorageVirtualMachine_tags --- PASS: TestAccFSxONTAPStorageVirtualMachine_disappears (2132.69s) === CONT TestAccFSxONTAPStorageVirtualMachine_rootVolumeSecurityStyle --- PASS: TestAccFSxONTAPStorageVirtualMachine_tags (2184.37s) --- PASS: TestAccFSxONTAPStorageVirtualMachine_rootVolumeSecurityStyle (2309.56s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/fsx 9185.799s
…e_directory_configuration attributes.
Community NoteVoting for Prioritization
For Submitters
|
…dministrators_group' on Read to prevent recreation.
…s_fsx_ontap_file_system-additions
active_directory_configuration
attributesactive_directory_configuration
attributes
This functionality has been released in v5.18.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
All
active_directory_configuration
attributes can now be update in place, allowing an SVM to join AD after creation.Also addresses various sweeper errors found while cleaning up after failed tests.
Relations
Closes #33199.
Closes #33198.
Output from Acceptance Testing