AWS SNS delivery failure feedback not set

[grimm26]

Hi there,

Thank you for opening an issue. Please note that we try to keep the Terraform issue tracker reserved for bug reports and feature requests. For general usage questions, please see: https://www.terraform.io/community.html.

Terraform Version

Terraform v0.11.3

Affected Resource(s)

• aws_sns_topic

Terraform Configuration Files

provider "aws" {}

resource "aws_sns_topic" "m" {
  name                                = "mktest2"
  lambda_success_feedback_role_arn    = "arn:aws:iam::112233445566:role/SNSSuccessFeedback"
  lambda_failure_feedback_role_arn    = "arn:aws:iam::112233445566:role/SNSFailureFeedback"
  lambda_success_feedback_sample_rate = "100"
}

Debug Output

https://gist.github.com/grimm26/3b88f0720cc68996959e8f739d075dda

Expected Behavior

Create success and failure feedback role arn settings in the topic.

Actual Behavior

only the success feedback arn was created.

Steps to Reproduce

See gist. Just try to use the parameters for lambda_success_feedback_role_arn and lambda_failure_feedback_role_arn

References

#2872

[grimm26]

actually, I'm having it sometimes do nothing or other pieces alone.
same config.

> $ terraform apply

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  + aws_sns_topic.m
      id:                                  <computed>
      arn:                                 <computed>
      lambda_failure_feedback_role_arn:    "arn:aws:iam::643927032162:role/SNSFailureFeedback"
      lambda_success_feedback_role_arn:    "arn:aws:iam::643927032162:role/SNSSuccessFeedback"
      lambda_success_feedback_sample_rate: "100"
      name:                                "mktest2"
      policy:                              <computed>


Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

aws_sns_topic.m: Creating...
  arn:                                 "" => "<computed>"
  lambda_failure_feedback_role_arn:    "" => "arn:aws:iam::643927032162:role/SNSFailureFeedback"
  lambda_success_feedback_role_arn:    "" => "arn:aws:iam::643927032162:role/SNSSuccessFeedback"
  lambda_success_feedback_sample_rate: "" => "100"
  name:                                "" => "mktest2"
  policy:                              "" => "<computed>"
aws_sns_topic.m: Creation complete after 0s (ID: arn:aws:sns:us-east-2:643927032162:mktest2)

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

> $ aws sns get-topic-attributes --topic-arn arn:aws:sns:us-east-2:643927032162:mktest2 --query 'Attributes.[LambdaSuccessFeedbackRoleArn, LambdaFailureFeedbackRoleArn,LambdaSuccessFeedbackSampleRate]'
[
    null,
    null,
    "100"
]

debug output: https://gist.github.com/grimm26/d0e9097b4e8b097a6553655bdefb57cd

[bflad]

@grimm26 can you confirm this works with multiple applies (one for each attribute)? I think I see the code error, but I'm really amazed the existing acceptance test didn't catch this 😓 .

[grimm26]

@bflad yep, if I comment the feedback settings out, apply, and then uncomment them one by one and apply for each, they all get applied.

[bflad]

Submitted bugfix PR: #3360

[bflad]

The fix for this has been merged into master and will be released with v1.10.0 of the AWS provider, likely at the end of this week.

[bflad]

This has been released in version 1.10.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!