-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timezone argument to aws_backup_plan #33653
Add timezone argument to aws_backup_plan #33653
Conversation
Community NoteVoting for Prioritization
For Submitters
|
This reverts commit 83f52a4.
This reverts commit a25f67a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccBackupPlan_' PKG=backup ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/backup/... -v -count 1 -parallel 3 -run=TestAccBackupPlan_ -timeout 360m
=== RUN TestAccBackupPlan_basic
=== PAUSE TestAccBackupPlan_basic
=== RUN TestAccBackupPlan_disappears
=== PAUSE TestAccBackupPlan_disappears
=== RUN TestAccBackupPlan_tags
=== PAUSE TestAccBackupPlan_tags
=== RUN TestAccBackupPlan_withRules
=== PAUSE TestAccBackupPlan_withRules
=== RUN TestAccBackupPlan_withLifecycle
=== PAUSE TestAccBackupPlan_withLifecycle
=== RUN TestAccBackupPlan_withRecoveryPointTags
=== PAUSE TestAccBackupPlan_withRecoveryPointTags
=== RUN TestAccBackupPlan_RuleCopyAction_sameRegion
=== PAUSE TestAccBackupPlan_RuleCopyAction_sameRegion
=== RUN TestAccBackupPlan_RuleCopyAction_noLifecycle
=== PAUSE TestAccBackupPlan_RuleCopyAction_noLifecycle
=== RUN TestAccBackupPlan_RuleCopyAction_multiple
=== PAUSE TestAccBackupPlan_RuleCopyAction_multiple
=== RUN TestAccBackupPlan_RuleCopyAction_crossRegion
=== PAUSE TestAccBackupPlan_RuleCopyAction_crossRegion
=== RUN TestAccBackupPlan_advancedBackupSetting
=== PAUSE TestAccBackupPlan_advancedBackupSetting
=== RUN TestAccBackupPlan_enableContinuousBackup
=== PAUSE TestAccBackupPlan_enableContinuousBackup
=== RUN TestAccBackupPlan_upgradeScheduleExpressionTimezone
=== PAUSE TestAccBackupPlan_upgradeScheduleExpressionTimezone
=== RUN TestAccBackupPlan_scheduleExpressionTimezone
=== PAUSE TestAccBackupPlan_scheduleExpressionTimezone
=== CONT TestAccBackupPlan_basic
=== CONT TestAccBackupPlan_RuleCopyAction_noLifecycle
=== CONT TestAccBackupPlan_enableContinuousBackup
--- PASS: TestAccBackupPlan_basic (14.77s)
=== CONT TestAccBackupPlan_scheduleExpressionTimezone
--- PASS: TestAccBackupPlan_enableContinuousBackup (14.77s)
=== CONT TestAccBackupPlan_upgradeScheduleExpressionTimezone
--- PASS: TestAccBackupPlan_RuleCopyAction_noLifecycle (33.78s)
=== CONT TestAccBackupPlan_tags
--- PASS: TestAccBackupPlan_scheduleExpressionTimezone (24.19s)
=== CONT TestAccBackupPlan_withRules
=== CONT TestAccBackupPlan_RuleCopyAction_crossRegion
--- PASS: TestAccBackupPlan_upgradeScheduleExpressionTimezone (42.54s)
--- PASS: TestAccBackupPlan_tags (32.59s)
=== CONT TestAccBackupPlan_advancedBackupSetting
--- PASS: TestAccBackupPlan_withRules (30.36s)
=== CONT TestAccBackupPlan_RuleCopyAction_sameRegion
--- PASS: TestAccBackupPlan_RuleCopyAction_crossRegion (20.61s)
=== CONT TestAccBackupPlan_RuleCopyAction_multiple
--- PASS: TestAccBackupPlan_advancedBackupSetting (21.65s)
=== CONT TestAccBackupPlan_withRecoveryPointTags
--- PASS: TestAccBackupPlan_RuleCopyAction_multiple (13.72s)
=== CONT TestAccBackupPlan_disappears
--- PASS: TestAccBackupPlan_RuleCopyAction_sameRegion (30.38s)
=== CONT TestAccBackupPlan_withLifecycle
--- PASS: TestAccBackupPlan_disappears (11.44s)
--- PASS: TestAccBackupPlan_withRecoveryPointTags (29.84s)
--- PASS: TestAccBackupPlan_withLifecycle (46.04s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/backup 151.194s
% make testacc TESTARGS='-run=TestAccBackupPlanDataSource_' PKG=backup ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/backup/... -v -count 1 -parallel 3 -run=TestAccBackupPlanDataSource_ -timeout 360m
=== RUN TestAccBackupPlanDataSource_basic
=== PAUSE TestAccBackupPlanDataSource_basic
=== CONT TestAccBackupPlanDataSource_basic
--- PASS: TestAccBackupPlanDataSource_basic (12.24s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/backup 17.578s
@autotune Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
The
aws_backup_plan
lets you set the cronschedule
in therule
block, but does not allow you to set which timezone the cron schedule should be evaluated in, which means that it defaults to UTC. The AWS console and the AWS CLI both support setting the timezone.Expected Terraform Configuration
Relations
Closes #33605
References
ScheduleExpressionTimezone
Output from Acceptance Testing