-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change min forward target group action rule to one per docs #33727
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc TESTS=TestAccELBV2ListenerRule_ PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2ListenerRule_' -timeout 360m
--- PASS: TestAccELBV2ListenerRule_conditionAttributesCount (441.72s)
=== CONT TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew
--- PASS: TestAccELBV2ListenerRule_conditionQueryString (902.20s)
=== CONT TestAccELBV2ListenerRule_oidc
--- PASS: TestAccELBV2ListenerRule_conditionPathPattern (906.63s)
=== CONT TestAccELBV2ListenerRule_cognito
--- PASS: TestAccELBV2ListenerRule_fixedResponse (915.86s)
=== CONT TestAccELBV2ListenerRule_conditionHTTPRequestMethod
--- PASS: TestAccELBV2ListenerRule_conditionMultiple (916.77s)
=== CONT TestAccELBV2ListenerRule_ConditionHTTPHeader_invalid
--- PASS: TestAccELBV2ListenerRule_conditionSourceIP (918.71s)
=== CONT TestAccELBV2ListenerRule_updateRulePriority
--- PASS: TestAccELBV2ListenerRule_conditionHostHeader (924.70s)
--- PASS: TestAccELBV2ListenerRule_conditionHTTPHeader (935.31s)
--- PASS: TestAccELBV2ListenerRule_ConditionHTTPHeader_invalid (20.89s)
--- PASS: TestAccELBV2ListenerRule_backwardsCompatibility (1074.18s)
--- PASS: TestAccELBV2ListenerRule_basic (1093.57s)
--- PASS: TestAccELBV2ListenerRule_disappears (1108.64s)
--- PASS: TestAccELBV2ListenerRule_Action_order (1128.40s)
--- PASS: TestAccELBV2ListenerRule_ActionOrder_recreates (1157.47s)
=== NAME TestAccELBV2ListenerRule_priority
listener_rule_test.go:540: Step 2/8 error: Check failed: Check 2/2 error: aws_lb_listener_rule.last: Attribute 'priority' expected "4", got "1"
--- PASS: TestAccELBV2ListenerRule_updateFixedResponse (1300.54s)
--- PASS: TestAccELBV2ListenerRule_conditionUpdateMultiple (1315.19s)
--- FAIL: TestAccELBV2ListenerRule_priority (1331.41s)
--- PASS: TestAccELBV2ListenerRule_redirect (1512.45s)
--- PASS: TestAccELBV2ListenerRule_conditionHTTPRequestMethod (623.31s)
--- PASS: TestAccELBV2ListenerRule_conditionUpdateMixed (1560.54s)
--- PASS: TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew (1122.80s)
--- PASS: TestAccELBV2ListenerRule_oidc (722.73s)
--- PASS: TestAccELBV2ListenerRule_tags (1671.71s)
--- PASS: TestAccELBV2ListenerRule_forwardWeighted (1679.47s)
--- PASS: TestAccELBV2ListenerRule_cognito (791.57s)
--- PASS: TestAccELBV2ListenerRule_updateRulePriority (836.99s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/elbv2 1759.308s
FAIL
make: *** [testacc] Error 1
Failure is unrelated to this change.
CreateRule documentation confirms a single target group argument is valid. https://docs.aws.amazon.com/elasticloadbalancing/latest/APIReference/API_Action.html
https://docs.aws.amazon.com/elasticloadbalancing/latest/APIReference/API_ForwardActionConfig.html
|
Thanks for your contribution, @autotune! 👏 |
This functionality has been released in v5.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
The following would error out because
target_group
inforward
schema was set to a minimum of two. Per the documentation, this should work correctly with a minimum of one.Relations
Closes #13636
Output from Acceptance Testing