DMS: Add GlueCatalogGeneration option to aws_dms_s3_endpoint

[nikoshet]

Description

This PR adds missing glue_catalog_generation to aws_dms_s3_endpoint resource. It also adds it to the s3_settings argument of aws_dms_endpoint resource for cross compatibility until it is removed in a future version.

Relations

Closes #33202

References

https://docs.aws.amazon.com/sdk-for-go/api/service/databasemigrationservice/#CreateEndpointInput
https://docs.aws.amazon.com/dms/latest/userguide/CHAP_Target.S3.html#CHAP_Target.S3.GlueCatalog

Output from Acceptance Testing

╰─$ make testacc TESTARGS='-run=TestAccDMSS3Endpoint_basic' PKG=dms                                                                                                                       130 ↵
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSS3Endpoint_basic -timeout 360m
=== RUN   TestAccDMSS3Endpoint_basic
=== PAUSE TestAccDMSS3Endpoint_basic
=== CONT  TestAccDMSS3Endpoint_basic
--- PASS: TestAccDMSS3Endpoint_basic (156.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        146.848s

╰─$ make testacc TESTARGS='-run=TestAccDMSS3Endpoint_simple' PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSS3Endpoint_simple -timeout 360m
=== RUN   TestAccDMSS3Endpoint_simple
=== PAUSE TestAccDMSS3Endpoint_simple
=== CONT  TestAccDMSS3Endpoint_simple
--- PASS: TestAccDMSS3Endpoint_simple (156.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        158.117s

╰─$ make testacc TESTARGS='-run=TestAccDMSS3Endpoint_update' PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSS3Endpoint_update -timeout 360m
=== RUN   TestAccDMSS3Endpoint_update
=== PAUSE TestAccDMSS3Endpoint_update
=== CONT  TestAccDMSS3Endpoint_update
--- PASS: TestAccDMSS3Endpoint_update (169.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        170.984s

╰─$ make testacc TESTARGS='-run=TestAccDMSS3Endpoint_sourceSimple' PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSS3Endpoint_sourceSimple -timeout 360m
=== RUN   TestAccDMSS3Endpoint_sourceSimple
=== PAUSE TestAccDMSS3Endpoint_sourceSimple
=== CONT  TestAccDMSS3Endpoint_sourceSimple
--- PASS: TestAccDMSS3Endpoint_sourceSimple (171.14s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        173.051s

╰─$ make testacc TESTARGS='-run=TestAccDMSEndpoint_S3_basic' PKG=dms      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSEndpoint_S3_basic -timeout 360m
=== RUN   TestAccDMSEndpoint_S3_basic
=== PAUSE TestAccDMSEndpoint_S3_basic
=== CONT  TestAccDMSEndpoint_S3_basic
--- PASS: TestAccDMSEndpoint_S3_basic (200.45s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        202.345s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @nikoshet 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDMSS3Endpoint_\|TestAccDMSEndpoint_S3\|TestAccDMSEndpoint_basic\|TestAccDMSEndpointDataSource_' PKG=dms ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 2  -run=TestAccDMSS3Endpoint_\|TestAccDMSEndpoint_S3\|TestAccDMSEndpoint_basic\|TestAccDMSEndpointDataSource_ -timeout 360m
=== RUN   TestAccDMSEndpointDataSource_basic
=== PAUSE TestAccDMSEndpointDataSource_basic
=== RUN   TestAccDMSEndpoint_basic
=== PAUSE TestAccDMSEndpoint_basic
=== RUN   TestAccDMSEndpoint_S3_basic
=== PAUSE TestAccDMSEndpoint_S3_basic
=== RUN   TestAccDMSEndpoint_S3_detachTargetOnLobLookupFailureParquet
=== PAUSE TestAccDMSEndpoint_S3_detachTargetOnLobLookupFailureParquet
=== RUN   TestAccDMSEndpoint_S3_key
=== PAUSE TestAccDMSEndpoint_S3_key
=== RUN   TestAccDMSEndpoint_S3_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_S3_extraConnectionAttributes
=== RUN   TestAccDMSEndpoint_S3_SSEKMSKeyARN
=== PAUSE TestAccDMSEndpoint_S3_SSEKMSKeyARN
=== RUN   TestAccDMSEndpoint_S3_SSEKMSKeyId
=== PAUSE TestAccDMSEndpoint_S3_SSEKMSKeyId
=== RUN   TestAccDMSS3Endpoint_basic
=== PAUSE TestAccDMSS3Endpoint_basic
=== RUN   TestAccDMSS3Endpoint_update
=== PAUSE TestAccDMSS3Endpoint_update
=== RUN   TestAccDMSS3Endpoint_simple
=== PAUSE TestAccDMSS3Endpoint_simple
=== RUN   TestAccDMSS3Endpoint_sourceSimple
=== PAUSE TestAccDMSS3Endpoint_sourceSimple
=== RUN   TestAccDMSS3Endpoint_source
=== PAUSE TestAccDMSS3Endpoint_source
=== RUN   TestAccDMSS3Endpoint_detachTargetOnLobLookupFailureParquet
=== PAUSE TestAccDMSS3Endpoint_detachTargetOnLobLookupFailureParquet
=== CONT  TestAccDMSEndpointDataSource_basic
=== CONT  TestAccDMSEndpoint_S3_SSEKMSKeyId
--- PASS: TestAccDMSEndpointDataSource_basic (24.34s)
=== CONT  TestAccDMSEndpoint_S3_key
--- PASS: TestAccDMSEndpoint_S3_key (11.75s)
=== CONT  TestAccDMSEndpoint_S3_SSEKMSKeyARN
--- PASS: TestAccDMSEndpoint_S3_SSEKMSKeyId (49.59s)
=== CONT  TestAccDMSEndpoint_S3_extraConnectionAttributes
--- PASS: TestAccDMSEndpoint_S3_SSEKMSKeyARN (47.36s)
=== CONT  TestAccDMSS3Endpoint_sourceSimple
--- PASS: TestAccDMSEndpoint_S3_extraConnectionAttributes (92.29s)
=== CONT  TestAccDMSS3Endpoint_detachTargetOnLobLookupFailureParquet
--- PASS: TestAccDMSS3Endpoint_sourceSimple (61.58s)
=== CONT  TestAccDMSS3Endpoint_source
--- PASS: TestAccDMSS3Endpoint_source (72.72s)
=== CONT  TestAccDMSEndpoint_S3_basic
--- PASS: TestAccDMSS3Endpoint_detachTargetOnLobLookupFailureParquet (95.30s)
=== CONT  TestAccDMSEndpoint_S3_detachTargetOnLobLookupFailureParquet
--- PASS: TestAccDMSEndpoint_S3_basic (95.50s)
=== CONT  TestAccDMSEndpoint_basic
--- PASS: TestAccDMSEndpoint_S3_detachTargetOnLobLookupFailureParquet (98.02s)
=== CONT  TestAccDMSS3Endpoint_update
--- PASS: TestAccDMSEndpoint_basic (56.64s)
=== CONT  TestAccDMSS3Endpoint_simple
--- PASS: TestAccDMSS3Endpoint_simple (48.54s)
=== CONT  TestAccDMSS3Endpoint_basic
--- PASS: TestAccDMSS3Endpoint_update (69.08s)
--- PASS: TestAccDMSS3Endpoint_basic (44.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	449.862s

[ewbankkit]

@nikoshet Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.