-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource bot version and add flattener for bot #33858
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM 🚀 . Just some small suggestions
$ make testacc TESTS=TestAccLexV2ModelsBotVersion_ PKG=lexv2models
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lexv2models/... -v -count 1 -parallel 20 -run='TestAccLexV2ModelsBotVersion_' -timeout 360m
=== RUN TestAccLexV2ModelsBotVersion_basic
=== PAUSE TestAccLexV2ModelsBotVersion_basic
=== RUN TestAccLexV2ModelsBotVersion_disappears
=== PAUSE TestAccLexV2ModelsBotVersion_disappears
=== CONT TestAccLexV2ModelsBotVersion_basic
=== CONT TestAccLexV2ModelsBotVersion_disappears
--- PASS: TestAccLexV2ModelsBotVersion_disappears (152.55s)
--- PASS: TestAccLexV2ModelsBotVersion_basic (153.32s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models 156.587s
This functionality has been released in v5.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add new resource bot version and add bot member flattener for bot
Relations
Relates #21375
Output from Acceptance Testing