-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_autoscaling_group: Force new in case of initial_lifecycle_hook update #34260
Conversation
Community NoteVoting for Prioritization
For Submitters
|
…ation block attributes to ForceNew.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAutoScalingGroup_initialLifecycleHook\|TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_simple\|TestAccAutoScalingLifecycleHook_basic' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2 -run=TestAccAutoScalingGroup_initialLifecycleHook\|TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_simple\|TestAccAutoScalingLifecycleHook_basic -timeout 360m
=== RUN TestAccAutoScalingGroup_basic
=== PAUSE TestAccAutoScalingGroup_basic
=== RUN TestAccAutoScalingGroup_simple
=== PAUSE TestAccAutoScalingGroup_simple
=== RUN TestAccAutoScalingGroup_initialLifecycleHook
=== PAUSE TestAccAutoScalingGroup_initialLifecycleHook
=== RUN TestAccAutoScalingLifecycleHook_basic
=== PAUSE TestAccAutoScalingLifecycleHook_basic
=== CONT TestAccAutoScalingGroup_basic
=== CONT TestAccAutoScalingGroup_initialLifecycleHook
--- PASS: TestAccAutoScalingGroup_basic (72.85s)
=== CONT TestAccAutoScalingGroup_simple
--- PASS: TestAccAutoScalingGroup_simple (199.49s)
=== CONT TestAccAutoScalingLifecycleHook_basic
--- PASS: TestAccAutoScalingLifecycleHook_basic (173.41s)
--- PASS: TestAccAutoScalingGroup_initialLifecycleHook (505.37s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 511.053s
@dhrkumar Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Fix a bug where if an
initial_lifecycle_hook
attribute is updated, it doesn't replaceaws_autoscaling_group
to applyinitial_lifecycle_hook
change.Relations
Closes #34178
Output from Acceptance Testing