Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chime service: fix race condition when not using us-east-1 #34334

Merged
merged 22 commits into from
Nov 13, 2023
Merged

chime service: fix race condition when not using us-east-1 #34334

merged 22 commits into from
Nov 13, 2023

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Nov 9, 2023 •
edited
Loading

Description

multiple fixes for eventual consistency errors.

Tests are now successful in regions other than us-east-1

Relations

Closes #34218

References

Output from Acceptance Testing

$ make testacc TESTARGS="-run=TestAccChime_serial" PKG=chime

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chime/... -v -count 1 -parallel 20  -run=TestAccChime_serial -timeout 360m
--- PASS: TestAccChime_serial (2349.97s)
    --- PASS: TestAccChime_serial/VoiceConnectorTerminationCredentials (427.25s)
        --- PASS: TestAccChime_serial/VoiceConnectorTerminationCredentials/disappears (110.37s)
        --- PASS: TestAccChime_serial/VoiceConnectorTerminationCredentials/update (199.87s)
        --- PASS: TestAccChime_serial/VoiceConnectorTerminationCredentials/basic (117.01s)
    --- PASS: TestAccChime_serial/VoiceConnector (338.63s)
        --- PASS: TestAccChime_serial/VoiceConnector/basic (58.42s)
        --- PASS: TestAccChime_serial/VoiceConnector/disappears (41.24s)
        --- PASS: TestAccChime_serial/VoiceConnector/update (95.37s)
        --- PASS: TestAccChime_serial/VoiceConnector/tags (143.61s)
    --- PASS: TestAccChime_serial/VoiceConnectorGroup (335.48s)
        --- PASS: TestAccChime_serial/VoiceConnectorGroup/basic (91.50s)
        --- PASS: TestAccChime_serial/VoiceConnectorGroup/disappears (85.25s)
        --- PASS: TestAccChime_serial/VoiceConnectorGroup/update (158.73s)
    --- PASS: TestAccChime_serial/VoiceConnectorLogging (319.68s)
        --- PASS: TestAccChime_serial/VoiceConnectorLogging/basic (86.02s)
        --- PASS: TestAccChime_serial/VoiceConnectorLogging/disappears (81.72s)
        --- PASS: TestAccChime_serial/VoiceConnectorLogging/update (151.94s)
    --- PASS: TestAccChime_serial/VoiceConnectorOrigination (311.77s)
        --- PASS: TestAccChime_serial/VoiceConnectorOrigination/basic (85.51s)
        --- PASS: TestAccChime_serial/VoiceConnectorOrigination/disappears (74.62s)
        --- PASS: TestAccChime_serial/VoiceConnectorOrigination/update (151.64s)
    --- PASS: TestAccChime_serial/VoiceConnectorStreaming (323.72s)
        --- PASS: TestAccChime_serial/VoiceConnectorStreaming/basic (61.08s)
        --- PASS: TestAccChime_serial/VoiceConnectorStreaming/disappears (59.67s)
        --- PASS: TestAccChime_serial/VoiceConnectorStreaming/update (202.97s)
    --- PASS: TestAccChime_serial/VoiceConnectorTermination (293.45s)
        --- PASS: TestAccChime_serial/VoiceConnectorTermination/update (142.66s)
        --- PASS: TestAccChime_serial/VoiceConnectorTermination/basic (81.38s)
        --- PASS: TestAccChime_serial/VoiceConnectorTermination/disappears (69.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/chime	2353.273s
$ make testacc TESTARGS="-run=TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_" PKG=chimesdkmediapipelines

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chimesdkmediapipelines/... -v -count 1 -parallel 20  -run=TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_ -timeout 360m
--- PASS: TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_disappears (137.72s)
--- PASS: TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_basic (182.36s)
--- PASS: TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_tags (270.45s)
--- PASS: TestAccChimeSDKMediaPipelinesMediaInsightsPipelineConfiguration_updateAllProcessorTypes (490.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/chimesdkmediapipelines	493.279s

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/chime Issues and PRs that pertain to the chime service. tags Pertains to resource tagging. generators Relates to code generators. labels Nov 9, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 9, 2023
@johnsonaj johnsonaj added the bug Addresses a defect in current functionality. label Nov 9, 2023
@johnsonaj johnsonaj marked this pull request as draft November 9, 2023 23:21
@johnsonaj johnsonaj marked this pull request as ready for review November 10, 2023 22:32
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/chimesdkmediapipelines Issues and PRs that pertain to the chimesdkmediapipelines service. and removed size/M Managed by automation to categorize the size of a PR. labels Nov 10, 2023
@johnsonaj johnsonaj changed the title r/chime_voice_connector: fix race condition when not using us-east-1 chime service: fix race condition when not using us-east-1 Nov 10, 2023
jar-b
jar-b approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc TESTARGS="-run=TestAccChime_serial" PKG=chime
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chime/... -v -count 1 -parallel 20  -run=TestAccChime_serial -timeout 360m

--- PASS: TestAccChime_serial (2445.11s)
    --- PASS: TestAccChime_serial/VoiceConnectorTerminationCredentials (433.09s)
        --- PASS: TestAccChime_serial/VoiceConnectorTerminationCredentials/basic (121.52s)
        --- PASS: TestAccChime_serial/VoiceConnectorTerminationCredentials/disappears (110.04s)
        --- PASS: TestAccChime_serial/VoiceConnectorTerminationCredentials/update (201.53s)
    --- PASS: TestAccChime_serial/VoiceConnector (345.52s)
        --- PASS: TestAccChime_serial/VoiceConnector/tags (146.52s)
        --- PASS: TestAccChime_serial/VoiceConnector/basic (59.08s)
        --- PASS: TestAccChime_serial/VoiceConnector/disappears (42.07s)
        --- PASS: TestAccChime_serial/VoiceConnector/update (97.84s)
    --- PASS: TestAccChime_serial/VoiceConnectorGroup (352.12s)
        --- PASS: TestAccChime_serial/VoiceConnectorGroup/basic (92.86s)
        --- PASS: TestAccChime_serial/VoiceConnectorGroup/disappears (90.64s)
        --- PASS: TestAccChime_serial/VoiceConnectorGroup/update (168.62s)
    --- PASS: TestAccChime_serial/VoiceConnectorLogging (337.65s)
        --- PASS: TestAccChime_serial/VoiceConnectorLogging/basic (92.57s)
        --- PASS: TestAccChime_serial/VoiceConnectorLogging/disappears (88.27s)
        --- PASS: TestAccChime_serial/VoiceConnectorLogging/update (156.81s)
    --- PASS: TestAccChime_serial/VoiceConnectorOrigination (322.38s)
        --- PASS: TestAccChime_serial/VoiceConnectorOrigination/update (157.44s)
        --- PASS: TestAccChime_serial/VoiceConnectorOrigination/basic (87.62s)
        --- PASS: TestAccChime_serial/VoiceConnectorOrigination/disappears (77.32s)
    --- PASS: TestAccChime_serial/VoiceConnectorStreaming (343.18s)
        --- PASS: TestAccChime_serial/VoiceConnectorStreaming/basic (61.70s)
        --- PASS: TestAccChime_serial/VoiceConnectorStreaming/disappears (70.94s)
        --- PASS: TestAccChime_serial/VoiceConnectorStreaming/update (210.54s)
    --- PASS: TestAccChime_serial/VoiceConnectorTermination (311.16s)
        --- PASS: TestAccChime_serial/VoiceConnectorTermination/basic (84.13s)
        --- PASS: TestAccChime_serial/VoiceConnectorTermination/disappears (73.90s)
        --- PASS: TestAccChime_serial/VoiceConnectorTermination/update (153.13s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/chime      2448.406s

internal/service/chime/voice_connector_test.go Outdated Show resolved Hide resolved
internal/service/chime/find.go Outdated Show resolved Hide resolved
@johnsonaj johnsonaj merged commit 5ff7ead into main Nov 13, 2023
36 checks passed
@johnsonaj johnsonaj deleted the b-chime_voice_connector_read branch November 13, 2023 18:17
@github-actions github-actions bot added this to the v5.26.0 milestone Nov 13, 2023
github-actions bot pushed a commit that referenced this pull request Nov 13, 2023
Update CHANGELOG.md for #34334
e0ed7a9
@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Nov 16, 2023
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/chime Issues and PRs that pertain to the chime service. service/chimesdkmediapipelines Issues and PRs that pertain to the chimesdkmediapipelines service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.26.0
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_chime_voice_connector and related resources error and auto-taint after SDK upgrade
3 participants
@johnsonaj @jar-b @justinretzolk