Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_neptune_parameter_group: Add name_prefix argument #34500

Conversation

williamlord-wise
Copy link

@williamlord-wise williamlord-wise commented Nov 21, 2023

Description

r/aws_neptune_parameter_group: Add name_prefix argument

Relations

Closes #34499

References

Output from Acceptance Testing

 % make testacc TESTS=TestAccNeptuneParameterGroup PKG=neptune
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 20 -run='TestAccNeptuneParameterGroup'  -timeout 360m
=== RUN   TestAccNeptuneParameterGroup_basic
=== PAUSE TestAccNeptuneParameterGroup_basic
=== RUN   TestAccNeptuneParameterGroup_nameGenerated
=== PAUSE TestAccNeptuneParameterGroup_nameGenerated
=== RUN   TestAccNeptuneParameterGroup_namePrefix
=== PAUSE TestAccNeptuneParameterGroup_namePrefix
=== RUN   TestAccNeptuneParameterGroup_description
=== PAUSE TestAccNeptuneParameterGroup_description
=== RUN   TestAccNeptuneParameterGroup_parameter
=== PAUSE TestAccNeptuneParameterGroup_parameter
=== RUN   TestAccNeptuneParameterGroup_tags
=== PAUSE TestAccNeptuneParameterGroup_tags
=== CONT  TestAccNeptuneParameterGroup_basic
=== CONT  TestAccNeptuneParameterGroup_description
=== CONT  TestAccNeptuneParameterGroup_tags
=== CONT  TestAccNeptuneParameterGroup_nameGenerated
=== CONT  TestAccNeptuneParameterGroup_parameter
=== CONT  TestAccNeptuneParameterGroup_namePrefix
--- PASS: TestAccNeptuneParameterGroup_namePrefix (158.83s)
--- PASS: TestAccNeptuneParameterGroup_basic (160.74s)
--- PASS: TestAccNeptuneParameterGroup_description (161.48s)
--- PASS: TestAccNeptuneParameterGroup_nameGenerated (162.31s)
--- PASS: TestAccNeptuneParameterGroup_parameter (238.21s)
--- PASS: TestAccNeptuneParameterGroup_tags (271.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/neptune    275.308s
...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/neptune Issues and PRs that pertain to the neptune service. labels Nov 21, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 21, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @williamlord-wise 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@williamlord-wise williamlord-wise marked this pull request as ready for review November 21, 2023 16:54
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Nov 28, 2023
@ewbankkit ewbankkit self-assigned this Nov 28, 2023
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 28, 2023
@ewbankkit
Copy link
Contributor

@williamlord-wise Thanks for the contribution 🎉 👏.
This functionality has been included in #34637.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/neptune Issues and PRs that pertain to the neptune service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
3 participants