Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: aws_controltower_landing_zone #34557

Closed
bschaatsbergen opened this issue Nov 26, 2023 · 12 comments · Fixed by #34595
Closed

[New Resource]: aws_controltower_landing_zone #34557

bschaatsbergen opened this issue Nov 26, 2023 · 12 comments · Fixed by #34595
Labels
new-resource Introduces a new resource. service/controltower Issues and PRs that pertain to the controltower service.
Milestone

Comments

@bschaatsbergen
Copy link
Member

bschaatsbergen commented Nov 26, 2023

Description

AWS Control Tower just announced API availability to manage Landing Zones: https://aws.amazon.com/about-aws/whats-new/2023/11/automate-aws-control-tower-zone-operations-apis/

Requested Resource(s) and/or Data Source(s)

aws_controltower_landing_zone

Potential Terraform Configuration

resource "aws_controltower_landing_zone" "example" {
  manifest = jsonencode(yamldecode(file("manifest.yaml")))
  version = "v1"
  tags = {
    Foo = "Bar"
  }
}

References

https://docs.aws.amazon.com/controltower/latest/APIReference/API_Operations.html

Would you like to implement a fix?

Yes, I'll pick this up 🚀

@github-actions github-actions bot added the service/controltower Issues and PRs that pertain to the controltower service. label Nov 26, 2023
@bschaatsbergen
Copy link
Member Author

bschaatsbergen commented Nov 26, 2023

Picking this up, but first I'll get #34558 done as it's a dependency

Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 26, 2023
@bschaatsbergen
Copy link
Member Author

bschaatsbergen commented Nov 28, 2023

This requires #34586 to be merged

@photosojourn
Copy link

Hey @bschaatsbergen thanks for picking this up. Do you have a rought eta on this feature being delivered?

@bschaatsbergen
Copy link
Member Author

bschaatsbergen commented Dec 7, 2023

Heya @photosojourn I aim to write the tests today/tomorrow. And informed the core team that I'm almost done implementing the resource. A review will have to take place by a core team member which I can't give an ETA on specifically but I expect it to happen fast.

@photosojourn
Copy link

Oooh excellent news and thanks!

@bschaatsbergen bschaatsbergen added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 7, 2023
@elad-ts
Copy link

elad-ts commented Jan 17, 2024

Hi @bschaatsbergen , any updates as i saw both #34586 and #34558 were merged.

Thank you very much!

@bschaatsbergen
Copy link
Member Author

Hey @elad-ts - thanks for checking up. We had some internal discussions around the resource specification and I believe that @ewbankkit is rounding up the PR.

@bschaatsbergen
Copy link
Member Author

bschaatsbergen commented Jan 28, 2024

Update on this issue: #34595 (comment) cc @elad-ts / @photosojourn

@bschaatsbergen
Copy link
Member Author

Update: We made all the changes after our internal discussions, and we plan to merge the pull request once all the checks are complete and successful. 👍🏼

@github-actions github-actions bot added this to the v5.36.0 milestone Feb 5, 2024
Copy link

github-actions bot commented Feb 8, 2024

This functionality has been released in v5.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/controltower Issues and PRs that pertain to the controltower service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants